Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Fix best disk tier on AWS to use the best IOPS #3836

Closed
wants to merge 1 commit into from
Closed

[AWS] Fix best disk tier on AWS to use the best IOPS #3836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sky/clouds/aws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ def _get_disk_specs(
disk_tier: Optional[resources_utils.DiskTier]) -> Dict[str, Any]:
tier = cls._translate_disk_tier(disk_tier)
tier2iops = {
resources_utils.DiskTier.HIGH: 7000,
resources_utils.DiskTier.HIGH: 16000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous IOPS was selected to keep the HIGH disk tier's performance for all clouds similar to each other. Should we instead create a new DiskTier.ULTRA for the max possible IOPS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. How about we change DiskTier.BEST to the actual best possible disk tier?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, BEST is the best DiskTier among LOW, MEDIUM, HIGH provided by SkyPilot right now (some clouds may not have HIGH tier, so BEST will map to MEDIUM in that case).

I am fine with changing the semantics of BEST to the actual best disk available on a specific cloud. This is related to #3585 and #3517.

resources_utils.DiskTier.MEDIUM: 3500,
resources_utils.DiskTier.LOW: 0, # only gp3 is required to set iops
}
Expand Down
Loading