[k8s] Fix generate_kubeconfig.sh when ingress is not used #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Sep 2, 2024
| @@ -169,6 +169,9 @@ roleRef: | |||
| kind: Role | |||
| name: skypilot-system-service-account-role | |||
| apiGroup: rbac.authorization.k8s.io | |||
| EOF | |||
| # Apply optional ingress-related roles, but don't make the script fail if it fails | |||
| kubectl apply -f - <<EOF || true | |||
There was a problem hiding this comment.
Should we echo some message when it fails?
There was a problem hiding this comment.
thanks, added!
| @@ -169,6 +169,9 @@ roleRef: | |||
| kind: Role | |||
| name: skypilot-system-service-account-role | |||
| apiGroup: rbac.authorization.k8s.io | |||
| EOF | |||
| # Apply optional ingress-related roles, but don't make the script fail if it fails | |||
| kubectl apply -f - <<EOF || true | |||
| --- | |||
There was a problem hiding this comment.
Do we need this --- here?
There was a problem hiding this comment.
good catch, removed now.
Michaelvll
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate_kubeconfig.sh would fail when a cluster doesn't have ingress:
This PR makes it optional, and any errors due to ingress not being present are ignored.