Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Fix generate_kubeconfig.sh when ingress is not used #3864

Merged
merged 2 commits into from
Sep 6, 2024
Merged

[k8s] Fix generate_kubeconfig.sh when ingress is not used #3864

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0850bd7
fix kubeconfig generate script
romilbhardwaj Aug 22, 2024
3b07685
updates
romilbhardwaj Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sky/utils/kubernetes/generate_kubeconfig.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ roleRef:
kind: Role
name: skypilot-system-service-account-role
apiGroup: rbac.authorization.k8s.io
EOF
# Apply optional ingress-related roles, but don't make the script fail if it fails
kubectl apply -f - <<EOF || true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we echo some message when it fails?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, added!

---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this --- here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, removed now.

# Optional: Role for accessing ingress resources
apiVersion: rbac.authorization.k8s.io/v1
Expand Down
Loading