Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Add retry for ssh max length #3884

Merged
merged 8 commits into from
Sep 2, 2024
Merged

[Core] Add retry for ssh max length #3884

merged 8 commits into from
Sep 2, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Aug 28, 2024 •
edited
Loading

Fixes #3859

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • pytest tests/test_smoke.py::test_long_setup_run_script
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll marked this pull request as ready for review August 30, 2024 23:12
@Michaelvll Michaelvll requested a review from cblmemo August 31, 2024 01:01
cblmemo
cblmemo approved these changes Aug 31, 2024
View reviewed changes
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @Michaelvll ! LGTM

@Michaelvll Michaelvll mentioned this pull request Aug 31, 2024
Closed
@Michaelvll Michaelvll added this pull request to the merge queue Sep 2, 2024
Merged via the queue into master with commit 0203971 Sep 2, 2024
20 checks passed
@Michaelvll Michaelvll deleted the retry-for-max-length branch September 2, 2024 22:37
@Michaelvll Michaelvll mentioned this pull request Sep 3, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblmemo cblmemo cblmemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Launching and job submission fails on MacOS
2 participants
@Michaelvll @cblmemo