Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to notify systemd of service readiness on linux #929

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

nbrownus
Copy link
Collaborator

This will send READY=1 to the unix domain socket described by the NOTIFY_SOCKET environment variable, if it was provided, after we have called Control.Activate().

Should resolve timing issues with services that depend on nebulas udp listener(s) and tun device being up.

Closes #921

johnmaguire
johnmaguire previously approved these changes Jul 24, 2023
Copy link
Collaborator

@johnmaguire johnmaguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

Copy link
Contributor

@jdoss jdoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nbrownus nbrownus merged commit 1e3c155 into master Jul 24, 2023
6 checks passed
@nbrownus nbrownus deleted the systemd-notify branch July 24, 2023 16:30
@wadey wadey added this to the v1.8.0 milestone Jul 24, 2023
@krabiswabbie
Copy link

Hello,

I wanted to report an ongoing issue with the example systemd service description provided in examples/service_scripts. Despite the feature being marked as resolved, I've found that Nebula fails to notify systemd of its successful startup when the systemd service is configured with Type=notify. As a result, the Nebula service continuously restarts due to a timeout.

This behavior is observed in the default installation of v1.7.2 on both amd64 and arm64 architectures. I'm aware that switching the systemd service type to simple is a workaround, but thought it would be beneficial for the team to know that the issue persists, especially considering it might affect new users trying to set up Nebula using the example provided.

Thank you for your dedication to this project.

@johnmaguire
Copy link
Collaborator

Hi @krabiswabbie - this PR has not made it into a release yet. You can try running one of the nightly builds now if you like: https://github.com/NebulaOSS/nebula-nightly/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample systemd unit "Before" insufficient
5 participants