-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Kitodo.Presentation 4 #208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restore tx-dlf-pagegrid-pagination class so that thumbnail page number looks like before. - Add padding to prevent bottom thumbnails from being partly hidden by paginator widget.
3 tasks
sebastian-meyer
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to finish the migration to Kitodo.Presentation 4 and Extbase/Fluid, and does some maintenance and fixes along the way. When merged, this resolves #201 and #205.
The migration relies on the following PRs to other repos:
(Needed to replace the custom calendar plugin)
So to test this:
Questions:
language.typoscript
has a language condition that looks obsolete to me (when using website language and site configuration). Is this right?In principle, they would work if the following is done:
0
suffixes of columnindex_name
in tablestx_dlf_metadata
andtx_dlf_structures
.data.xml
to avoid these suffixes on fresh install, but couldn't find a way so far. Even when reordering the entries, it looks like TYPO3'sDataHandler::getUnique()
won't detect the translated records as such because thel18n_parent
doesn't yet have an ID.