Chore: update config #1387
Open
Chore: update config #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelloKashif
reviewed
Aug 28, 2024
Comment on lines
+17
to
+18
| TipCapDefault = '5 gwei' | ||
| TipCapMin = '1 gwei' |
There was a problem hiding this comment.
Do we need such high tip? This was set for testnet as it fluctuates a lot more.
Shall we have the DS&A values here instead?
There was a problem hiding this comment.
Also same comment for other mainnets as well
There was a problem hiding this comment.
yes what are the DS&A values again?
|
stackman27
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
stackman27
force-pushed
the
sish/zkchains-config
branch
from
69f4fbb
to
aa07fd5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution