-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update config #1387
Open
stackman27
wants to merge
7
commits into
ccip-develop
Choose a base branch
from
sish/zkchains-config
base: ccip-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chore: update config #1387
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,28 @@ | ||
ChainID = '59144' | ||
# Block time 12s, finality < 60m | ||
FinalityDepth = 300 | ||
# Blocks are only emitted when a transaction happens / no empty blocks | ||
NoNewHeadsThreshold = '0' | ||
FinalityTagEnabled = false | ||
FinalityDepth = 600 #3s block time ~ 20m finality based on committee decision | ||
NoNewHeadsThreshold = '0' #No empty blocks | ||
|
||
[GasEstimator] | ||
BumpPercent = 40 | ||
PriceMin = '400 mwei' | ||
[HeadTracker] | ||
HistoryDepth = 1000 | ||
|
||
[Transactions] | ||
# increase resend time to align with finality | ||
ResendAfterThreshold = '3m' | ||
ResendAfterThreshold = '30s' | ||
|
||
# set greater than finality depth | ||
[HeadTracker] | ||
HistoryDepth = 350 | ||
[GasEstimator] | ||
BumpPercent = 10 | ||
BumpThreshold = 10 | ||
EIP1559DynamicFees = true | ||
FeeCapDefault = '2500 gwei' | ||
TipCapDefault = '5 gwei' | ||
TipCapMin = '1 gwei' | ||
LimitDefault = 8000000 | ||
|
||
[GasEstimator.BlockHistory] | ||
BlockHistorySize = 200 | ||
CheckInclusionBlocks = 0 #required for AutoPurge zkoverflow replacement | ||
|
||
[Transactions.AutoPurge] | ||
Enabled = true | ||
Threshold = 50 # 50 blocks at 3s block time ~2.5 minutes | ||
MinAttempts = 3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,28 @@ | ||
ChainID = '59141' | ||
FinalityDepth = 900 | ||
NoNewHeadsThreshold = '0' | ||
FinalityTagEnabled = false | ||
FinalityDepth = 600 #3s block time ~ 20m finality based on committee decision | ||
NoNewHeadsThreshold = '0' #No empty blocks | ||
|
||
[HeadTracker] | ||
HistoryDepth = 1000 | ||
|
||
[Transactions] | ||
ResendAfterThreshold = '30s' | ||
|
||
[GasEstimator] | ||
BumpPercent = 10 | ||
BumpThreshold = 10 | ||
EIP1559DynamicFees = true | ||
PriceMin = '1 wei' | ||
FeeCapDefault = '2500 gwei' | ||
TipCapDefault = '5 gwei' | ||
TipCapMin = '1 gwei' | ||
LimitDefault = 8000000 | ||
|
||
[Transactions] | ||
ResendAfterThreshold = '3m' | ||
[GasEstimator.BlockHistory] | ||
BlockHistorySize = 200 | ||
CheckInclusionBlocks = 0 #required for AutoPurge zkoverflow replacement | ||
|
||
[HeadTracker] | ||
HistoryDepth = 1000 | ||
[Transactions.AutoPurge] | ||
Enabled = true | ||
Threshold = 50 # 50 blocks at 3s block time ~2.5 minutes | ||
MinAttempts = 3 |
18 changes: 15 additions & 3 deletions
18
core/chains/evm/config/toml/defaults/Polygon_Zkevm_Cardona.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need such high tip? This was set for testnet as it fluctuates a lot more.
Shall we have the DS&A values here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also same comment for other mainnets as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes what are the DS&A values again?