-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add solana checks to make file #407
base: main
Are you sure you want to change the base?
Conversation
Could you put this in a make target? Something like "make solana_checks". The pre commit config would call the target (and maybe do the yubi key thing). We could also call that target as part of CI to ensure these files are always consistent. Add a call to the new target here:
|
All Solana Validations are run in https://github.com/smartcontractkit/chainlink-ccip/blob/feat/add-docs/.github/workflows/solana.yml The pre-commit hook is just for local dev |
|
cd ./contracts && anchor build | ||
|
||
.PHONY: solana-checks | ||
solana-checks: clippy anchor-go-gen format gomodtidy lint-go rust-tests go-tests build-contracts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anchor-go-gen
is already building the contracts, could you please remove that redundancy to bring down the time it takes to run this command?
solana-checks: clippy anchor-go-gen format gomodtidy lint-go rust-tests go-tests build-contracts | |
solana-checks: clippy anchor-go-gen format gomodtidy lint-go rust-tests go-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I needed it to recreate the IDL, as the tests modify them adding the program_ids
The Solana Contracts have many validations regarding format and autogenerated code, this new make command needs to be run only when a file under
chains/solana
was modified and auto fix style issues, and auto generates all needed files.