Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solana checks to make file #407

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add solana checks to make file #407

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3e2231b
Add pre commit
agusaldasoro Dec 26, 2024
6989a84
Refactor makefile
agusaldasoro Dec 30, 2024
92cb3d6
Merge branch 'main' into feat/add-docs
agusaldasoro Dec 30, 2024
5f946f4
Fix pre commit hook
agusaldasoro Dec 30, 2024
f90255f
Merge branch 'main' into feat/add-docs
agusaldasoro Dec 30, 2024
1ff1a05
Remove edited files
agusaldasoro Jan 2, 2025
e1a3356
undo readme
agusaldasoro Jan 2, 2025
ed95c8f
rename task
agusaldasoro Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions chains/solana/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ export ANCHOR_IMAGE ?= backpackapp/build:$(ANCHOR_VERSION)
anchor_version:
@echo "${ANCHOR_VERSION}"

.PHONY: clippy
clippy:
cargo clippy --manifest-path ./contracts/programs/ccip-router/Cargo.toml

.PHONY: gomods
gomods: ## Install gomods
go install github.com/jmank88/[email protected]
Expand Down Expand Up @@ -44,6 +48,9 @@ format:
go-tests:
go test -v ./... -json -covermode=atomic -coverpkg=./... -coverprofile=integration_coverage.txt 2>&1 | tee /tmp/gotest.log | gotestloghelper -ci=true -singlepackage=true -hidepassingtests=false -hidepassinglogs=false

.PHONY: generate-idl
generate-idl:
.PHONY: build-contracts
build-contracts:
cd ./contracts && anchor build

.PHONY: solana-checks
solana-checks: clippy anchor-go-gen format gomodtidy lint-go rust-tests go-tests build-contracts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchor-go-gen is already building the contracts, could you please remove that redundancy to bring down the time it takes to run this command?

Suggested change
solana-checks: clippy anchor-go-gen format gomodtidy lint-go rust-tests go-tests build-contracts
solana-checks: clippy anchor-go-gen format gomodtidy lint-go rust-tests go-tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I needed it to recreate the IDL, as the tests modify them adding the program_ids

Loading