Add pkg/pg with dialects.go & txdb.go #910
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
had a problem deploying
to
integration
GitHub Actions
Failure
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
Neither of these were in the actual pg package in chainlink repo. dialects.go came from core/store/dialects and txdb.go from core/internal/testutils/pgtest, but neither of these seem like they deserve their own package in chainlink-common--we can lump all the postgres specific common utilities under pkg/pg
reductionista
force-pushed
the
NONEVM-739/txdb
branch
from
86478ad
to
8e479fe
Compare
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
had a problem deploying
to
integration
GitHub Actions
Error
reductionista
had a problem deploying
to
integration
GitHub Actions
Error
Also: convert rest of panic isn't ordinary errors
reductionista
force-pushed
the
NONEVM-739/txdb
branch
from
213ae02
to
9035c2a
Compare
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
temporarily deployed
to
integration
GitHub Actions
Inactive
| tests.SkipShortDB(t) | ||
| err := RegisterTxDb(dbURL) | ||
| if err != nil { | ||
| t.Errorf("failed to register txdb dialect: %s", err.Error()) |
There was a problem hiding this comment.
should not this be a fatal error?
Otherwise caller has to check if returned db is nil.
| func TestTxDBDriver(t *testing.T) { | ||
| dbURL, ok := os.LookupEnv("CL_DATABASE_URL") | ||
| require.True(t, ok, "CL_DATABASE_URL must be set") | ||
| db := NewSqlxDB(t, dbURL) |
There was a problem hiding this comment.
I've noticed weird behavior in my PR. If two tests use db and run sequentially, second fails with conn closed error.
There was a problem hiding this comment.
Ah, I think I know why that's happening. I changed txdb to use the test context for queries instead of context.Background, thinking that was an improvement over what's currently in chainlink repo. But apparently that won't work--we'll have to put it back to context.Background, I guess there's just no context that would survive long enough for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NONEVM-739
Supports
smartcontractkit/chainlink#15064
smartcontractkit/chainlink-solana#921
Neither of these were in the actual pg package in chainlink repo. dialects.go came from core/store/dialects and txdb.go from core/internal/testutils/pgtest, but neither of these seem like they deserve their own package in chainlink-common--we can lump all the postgres specific common utilities under pkg/pg (TODO: change to pkg/sqlutils/pg to match Jordan's PR]