-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pkg/pg with dialects.go & txdb.go #910
Draft
reductionista
wants to merge
5
commits into
main
Choose a base branch
from
NONEVM-739/txdb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
71d5ca5
Add pkg/pg with dialects.go & txdb.go
reductionista 722239b
Add TestTxDBDriver, NewSqlxDB, SkipShort, SkipShortDB and SkipFlakey
reductionista c540333
Add idempotency test of RegisterTxDb
reductionista 8e479fe
Create ctx from testing context, instead of using context.Background
reductionista 9035c2a
Only abort tx's when last connection is closed
reductionista File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package pg | ||
|
||
import ( | ||
// need to make sure pgx driver is registered before opening connection | ||
_ "github.com/jackc/pgx/v4/stdlib" | ||
) | ||
|
||
// DialectName is a compiler enforced type used that maps to database dialect names | ||
type DialectName string | ||
|
||
const ( | ||
// Postgres represents the postgres dialect. | ||
Postgres DialectName = "pgx" | ||
// TransactionWrappedPostgres is useful for tests. | ||
// When the connection is opened, it starts a transaction and all | ||
// operations performed on the DB will be within that transaction. | ||
TransactionWrappedPostgres DialectName = "txdb" | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package pg | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/google/uuid" | ||
"github.com/jmoiron/sqlx" | ||
"github.com/scylladb/go-reflectx" | ||
"github.com/stretchr/testify/assert" | ||
"github.com/stretchr/testify/require" | ||
|
||
"github.com/smartcontractkit/chainlink-common/pkg/utils/tests" | ||
) | ||
|
||
func NewSqlxDB(t testing.TB, dbURL string) *sqlx.DB { | ||
tests.SkipShortDB(t) | ||
err := RegisterTxDb(dbURL) | ||
if err != nil { | ||
t.Errorf("failed to register txdb dialect: %s", err.Error()) | ||
return nil | ||
} | ||
db, err := sqlx.Open(string(TransactionWrappedPostgres), uuid.New().String()) | ||
require.NoError(t, err) | ||
t.Cleanup(func() { assert.NoError(t, db.Close()) }) | ||
db.MapperFunc(reflectx.CamelToSnakeASCII) | ||
|
||
return db | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not this be a fatal error?
Otherwise caller has to check if returned db is nil.