Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ChainSet LatestHead #419

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Implement ChainSet LatestHead #419

merged 8 commits into from
Sep 11, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Sep 10, 2024 •
edited
Loading

core ref: 18cc10abf0941edea0193afe56f9b4b23ab4a3f1

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

This was referenced Sep 10, 2024
Merged
Merged
Merged
Merged
@ilija42 ilija42 marked this pull request as ready for review September 11, 2024 09:43
Farber98
Farber98 previously approved these changes Sep 11, 2024
View reviewed changes
Farber98
Farber98 previously approved these changes Sep 11, 2024
View reviewed changes
silaslenihan
silaslenihan previously approved these changes Sep 11, 2024
View reviewed changes
Copy link

@silaslenihan silaslenihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilija42 ilija42 mentioned this pull request Sep 11, 2024
Merged
Farber98
Farber98 previously approved these changes Sep 11, 2024
View reviewed changes
silaslenihan
silaslenihan previously approved these changes Sep 11, 2024
View reviewed changes
@ilija42 ilija42 dismissed stale reviews from silaslenihan and Farber98 via c1da282 September 11, 2024 16:00
Farber98
Farber98 previously approved these changes Sep 11, 2024
View reviewed changes
silaslenihan
silaslenihan previously approved these changes Sep 11, 2024
View reviewed changes
@ilija42 ilija42 dismissed stale reviews from silaslenihan and Farber98 via db9e63e September 11, 2024 16:51
silaslenihan
silaslenihan previously approved these changes Sep 11, 2024
View reviewed changes
@ilija42 ilija42 merged commit daf2600 into develop Sep 11, 2024
15 of 16 checks passed
@ilija42 ilija42 deleted the BCF-3381-expose-latest-heads branch September 11, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silaslenihan silaslenihan silaslenihan approved these changes

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny

@kidambisrinivas kidambisrinivas Awaiting requested review from kidambisrinivas

@Farber98 Farber98 Awaiting requested review from Farber98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilija42 @kidambisrinivas @silaslenihan @Farber98