Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCF-3381] - Implement changeset LatestHead #521

Merged
merged 10 commits into from
Sep 11, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Sep 10, 2024

core ref: 9eb801069a307d5495036f8f716ff277db95b4be

@ilija42 ilija42 marked this pull request as draft September 10, 2024 23:07
@ilija42 ilija42 marked this pull request as ready for review September 11, 2024 09:33
Farber98
Farber98 previously approved these changes Sep 11, 2024
Copy link
Collaborator

@augustbleeds augustbleeds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilija42 changes look good. but it's hard to know if this will break e2e tests since you're introducing some changes in the integration tests folder.

when will the corresponding relayer changes be pushed to core (chainlink)? We are actively going to be pushing new contracts and modifying the e2e tests this sprint so I want to make sure that the e2e tests are green within 1 day of this PR being merged in.

@ilija42
Copy link
Contributor Author

ilija42 commented Sep 11, 2024

@ilija42 changes look good. but it's hard to know if this will break e2e tests since you're introducing some changes in the integration tests folder.

when will the corresponding relayer changes be pushed to core (chainlink)? We are actively going to be pushing new contracts and modifying the e2e tests this sprint so I want to make sure that the e2e tests are green within 1 day of this PR being merged in.

Starknet tests were passing in the chainlink-common Starknet integration test, should be the same thing? All of the changes in core will be merged within an hour.

@augustbleeds
Copy link
Collaborator

@ilija42 changes look good. but it's hard to know if this will break e2e tests since you're introducing some changes in the integration tests folder.
when will the corresponding relayer changes be pushed to core (chainlink)? We are actively going to be pushing new contracts and modifying the e2e tests this sprint so I want to make sure that the e2e tests are green within 1 day of this PR being merged in.

Starknet tests were passing in the chainlink-common Starknet integration test, should be the same thing? All of the changes in core will be merged within an hour.

Thanks! I'll add the ability to test the custom core reference #524 and then we can retest

@augustbleeds
Copy link
Collaborator

augustbleeds commented Sep 11, 2024

yay it's working -- i love seeing the ✅ .

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@ilija42 ilija42 merged commit 506bc46 into develop Sep 11, 2024
21 of 22 checks passed
@ilija42 ilija42 deleted the BCF-3381-expose-latest-heads branch September 11, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants