-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BCF-3381] - Implement changeset LatestHead #521
Conversation
1accbe1
9e8d2de
to
1accbe1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilija42 changes look good. but it's hard to know if this will break e2e tests since you're introducing some changes in the integration tests folder.
when will the corresponding relayer changes be pushed to core (chainlink)? We are actively going to be pushing new contracts and modifying the e2e tests this sprint so I want to make sure that the e2e tests are green within 1 day of this PR being merged in.
Starknet tests were passing in the chainlink-common Starknet integration test, should be the same thing? All of the changes in core will be merged within an hour. |
Thanks! I'll add the ability to test the custom core reference #524 and then we can retest |
yay it's working -- i love seeing the ✅ . |
Quality Gate failedFailed conditions |
core ref: 9eb801069a307d5495036f8f716ff277db95b4be