multinode: remove generic result type #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine, is there an associated PR for the main chainlink repo? |
pavel-raykov
previously approved these changes
Jan 20, 2025
jmank88
force-pushed
the
rm-generic-result
branch
from
6766da3 to
efd7093
Compare
pavel-raykov
previously approved these changes
Jan 22, 2025
jmank88
force-pushed
the
rm-generic-result
branch
from
efd7093 to
9783fa9
Compare
jmank88
force-pushed
the
rm-generic-result
branch
from
9783fa9 to
5012d4f
Compare
jmank88
commented
Jan 30, 2025
| type SendTxResult interface { | ||
| Code() SendTxReturnCode | ||
| Error() error | ||
| type sendTxResult[RESULT any] struct { |
There was a problem hiding this comment.
Instead of requiring this interface to be implemented by each user, we can use a struct internally, and multivalue returns with a plain generic result value. This sheds a ton of boilerplate, including the constructor function.
pavel-raykov
approved these changes
Jan 31, 2025
DylanTinianov
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating
SendTxReturnCodeI noticed that this exported and generic result wrapper type is not really necessary.Supports