bump framework; remove generic result type #15995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
pavel-raykov
previously approved these changes
Jan 20, 2025
jmank88
force-pushed
the
rm-generic-result
branch
2 times, most recently
from
ee936a7 to
4154bea
Compare
pavel-raykov
previously approved these changes
Jan 22, 2025
jmank88
force-pushed
the
rm-generic-result
branch
from
4154bea to
80c3b9f
Compare
pavel-raykov
previously approved these changes
Jan 31, 2025
DylanTinianov
previously approved these changes
Feb 3, 2025
jmank88
dismissed stale reviews from DylanTinianov and pavel-raykov
via
d9da97d
jmank88
force-pushed
the
rm-generic-result
branch
7 times, most recently
from
4096090 to
bd4b7f5
Compare
jmank88
force-pushed
the
rm-generic-result
branch
from
62ba6ee to
92e400f
Compare
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
jmank88
force-pushed
the
rm-generic-result
branch
from
92e400f to
75a6166
Compare
jmank88
force-pushed
the
rm-generic-result
branch
3 times, most recently
from
683a2a8 to
b2d93af
Compare
jmank88
requested review from
EasterTheBunny,
Atrax1,
pavel-raykov and
dhaidashenko
samsondav
previously approved these changes
Feb 5, 2025
| @@ -90,6 +90,7 @@ func NewTestEthBroadcaster( | |||
| // Mark instance as test | |||
| ethBroadcaster.XXXTestDisableUnstartedTxAutoProcessing() | |||
| servicetest.Run(t, ethBroadcaster) | |||
| time.Sleep(time.Second) // let background initiate | |||
There was a problem hiding this comment.
urgh, can we make this deterministic by waiting for a log message?
There was a problem hiding this comment.
I think waiting for .Ready() would be more robust, but it will require more changes and I didn't want this to snowball any more since it was incidental in this unrelated changeset. OK to follow up?
https://smartcontract-it.atlassian.net/browse/CRE-268
jmank88
force-pushed
the
rm-generic-result
branch
from
b2d93af to
001c3c4
Compare
|
pavel-raykov
approved these changes
Feb 6, 2025
jmank88
requested review from
cedric-cordenier,
george-dorin and
poopoothegorilla
dhaidashenko
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump framework for generic simplifications.
This also incidentally picked up smartcontractkit/chainlink-framework#18, which caused smoke test failures from unclean logs. It is resolved by smartcontractkit/chainlink-framework#23
Requires