Use test secrets for E2E tests #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smickovskid
had a problem deploying
to
integration
GitHub Actions
Failure
smickovskid
previously approved these changes
Aug 21, 2024
aalu1418
requested changes
Aug 21, 2024
Comment on lines
+418
to
+421
| env: | ||
| E2E_TEST_CHAINLINK_IMAGE: ${{ env.CL_ECR }} | ||
| E2E_TEST_SOLANA_SECRET: thisisatestingonlysecret | ||
|
|
There was a problem hiding this comment.
is there also a core side PR that updates the solana e2e in the chainlink repo?
otherwise updating the chainlink-solana ref in core may cause the solana e2e tests in there to break if these changes are not backwards compatible
There was a problem hiding this comment.
addressing this here: smartcontractkit/chainlink#14332
since it's now blocking other e2e test updates
|
aalu1418
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're updating how we manage test secrets on GitHub CI to enhance security. Instead of passing secrets like the Chainlink image name or wallet key in test config, we will now load them from the
~/.testsecretsfile in your home directory. When running on Github CI custom secrets can be provided intest_secrets_override_keyinput.Full guide: https://github.com/smartcontractkit/chainlink-testing-framework/blob/main/config/README.md#test-secrets