Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiNode Integration: TOML Configurations #844

Open
wants to merge 39 commits into
base: develop
Choose a base branch
from
Open

MultiNode Integration: TOML Configurations #844

wants to merge 39 commits into from

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Sep 6, 2024 •
edited
Loading

Description

Added required TOML configurations for MultiNode integration.

Closes: https://smartcontract-it.atlassian.net/browse/BCFR-302

Requires Dependencies

This PR is a follow up to the MultiNode Initial Setup PR: #824

@DylanTinianov DylanTinianov self-assigned this Sep 6, 2024
@DylanTinianov DylanTinianov marked this pull request as ready for review September 24, 2024 16:29
@DylanTinianov DylanTinianov requested a review from a team as a code owner September 24, 2024 16:29
patrick-dowell
patrick-dowell reviewed Sep 24, 2024
View reviewed changes
Copy link

@patrick-dowell patrick-dowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments around cleaning up this code.

pkg/solana/config/multinode.go
c.multiNodeEnabled = ptr(false)

// Node Configs
c.pollFailureThreshold = ptr(uint32(5))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values here - where are they coming from? For example, the 5 for syncThreshold or the 10 for pollInterval. Could these come from another source or if they are to be hardcoded, could we provide some documentation as to why these are the best default values for these fields?

Copy link
Contributor Author

@DylanTinianov DylanTinianov Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a meeting with Dmytro and Aaron where we discussed what default values make sense for each config. I can for sure add some comments though!

pkg/solana/config/multinode.go Outdated Show resolved Hide resolved
aalu1418
aalu1418 requested changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually changing TOML configs requires updating tests in core with default values

please link a draft PR in core that bumps chainlink-solana in core and validates that all tests are passing

@DylanTinianov DylanTinianov mentioned this pull request Sep 26, 2024
Draft
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
30.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-dowell patrick-dowell patrick-dowell left review comments

@aalu1418 aalu1418 aalu1418 requested changes

@dhaidashenko dhaidashenko Awaiting requested review from dhaidashenko

Requested changes must be addressed to merge this pull request.

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DylanTinianov @patrick-dowell @aalu1418