Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Chainlink-relay for grpc proxy #317

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Bump Chainlink-relay for grpc proxy #317

merged 1 commit into from
Aug 10, 2023

Conversation

yongkangc
Copy link
Contributor

@yongkangc yongkangc temporarily deployed to integration August 9, 2023 00:34 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration August 9, 2023 00:34 — with GitHub Actions Inactive
jmank88
jmank88 previously approved these changes Aug 9, 2023
View reviewed changes
@yongkangc yongkangc temporarily deployed to integration August 9, 2023 00:56 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration August 9, 2023 00:56 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration August 9, 2023 19:05 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration August 9, 2023 19:05 — with GitHub Actions Inactive
@aalu1418 aalu1418 temporarily deployed to integration August 9, 2023 20:15 — with GitHub Actions Inactive
@aalu1418 aalu1418 temporarily deployed to integration August 9, 2023 20:15 — with GitHub Actions Inactive
@aalu1418 aalu1418 temporarily deployed to integration August 9, 2023 20:44 — with GitHub Actions Inactive
@aalu1418 aalu1418 temporarily deployed to integration August 9, 2023 20:44 — with GitHub Actions Inactive
@aalu1418 aalu1418 temporarily deployed to integration August 9, 2023 20:44 — with GitHub Actions Inactive
@aalu1418 aalu1418 temporarily deployed to integration August 9, 2023 20:55 — with GitHub Actions Inactive
@aalu1418 aalu1418 temporarily deployed to integration August 9, 2023 20:55 — with GitHub Actions Inactive
@yongkangc yongkangc requested a review from aalu1418 August 9, 2023 20:58
aalu1418
aalu1418 reviewed Aug 9, 2023
View reviewed changes
integration-tests/infra_deployments/deployer_test.go
URL: nodeUrl[0],
Email: nodeUrl[1],
Password: nodeUrl[2],
InternalIP: u.Host,
})
}, "", "")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smickovskid is this ok to leave empty?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will perhaps even delete this in the future, this was a workaround so we can deploy on an already deployed cluster. It can be like this for now

@yongkangc yongkangc requested a review from archseer August 9, 2023 21:13
@yongkangc
Copy link
Contributor Author

@aalu1418 helped to figure out the issues with dependencies. It was mostly dependencies bumping, but there are also fixes to e2e tests. Right now its pending @smickovskid to approve of Aarons changes to the e2e tests.

@archseer also mentioned how the contract/gauntlet tests fail because hardhat-starknet-plugin doesn't support latest cairo versions yet

@yongkangc yongkangc requested a review from jmank88 August 9, 2023 21:21
@aalu1418 aalu1418 mentioned this pull request Aug 9, 2023
Closed
@yongkangc yongkangc mentioned this pull request Aug 10, 2023
Merged
aalu1418
aalu1418 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving - @smickovskid approved the changes 😄

@yongkangc
Bump Chainlink-relay for grpc proxy
c585aa9 
Bump other go.mod files for grpc proxy dependency

bump necessary deps

integration test updates
@yongkangc yongkangc temporarily deployed to integration August 10, 2023 15:21 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration August 10, 2023 15:21 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration August 10, 2023 15:21 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration August 10, 2023 15:32 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration August 10, 2023 15:32 — with GitHub Actions Inactive
@jmank88 jmank88 merged commit 185d226 into develop Aug 10, 2023
13 of 16 checks passed
@jmank88 jmank88 deleted the BCI-1702 branch August 10, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@jmank88 jmank88 jmank88 approved these changes

@bolekk bolekk Awaiting requested review from bolekk

@smickovskid smickovskid Awaiting requested review from smickovskid

@archseer archseer Awaiting requested review from archseer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yongkangc @jmank88 @smickovskid @aalu1418