Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TXM In-memory: address_state methods: step 3-02 #12176

Closed
wants to merge 45 commits into from
Closed

TXM In-memory: address_state methods: step 3-02 #12176

wants to merge 45 commits into from

Conversation

poopoothegorilla
Copy link
Contributor

@poopoothegorilla poopoothegorilla commented Feb 26, 2024 •
edited
Loading

NOTES:

  • Implements 5 methods for the AddressState component
  • Removes return errors for Peeks and instead returns nils if nothing found
  • Returns error if Tx with the same idempodency key exists already when trying to add to UnstartedQueue

Parent PR:

@poopoothegorilla poopoothegorilla changed the base branch from develop to jtw/step-3-in-memory-work February 26, 2024 20:57
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@poopoothegorilla poopoothegorilla mentioned this pull request Feb 26, 2024
Closed
This was referenced Feb 26, 2024
Closed
Merged
This was referenced Feb 29, 2024
Merged
Merged
Merged
@poopoothegorilla
Copy link
Contributor Author

#12181 (comment)

@poopoothegorilla
Merge pull request #12181 from smartcontractkit/jtw/step-3-02-create-…
ef5b26a 
…transaction

TXM In-memory: step 3-02-CreateTransaction
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 5, 2024
@github-actions github-actions bot closed this Jun 12, 2024
@amit-momin amit-momin reopened this Jun 26, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@amit-momin amit-momin removed the Stale label Jun 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 27, 2024
@github-actions github-actions bot closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poopoothegorilla @prashantkumar1982 @amit-momin