Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm spec factory #14458

Merged
merged 23 commits into from
Sep 25, 2024
Merged

Add wasm spec factory #14458

merged 23 commits into from
Sep 25, 2024

Conversation

nolag
Copy link
Contributor

@nolag nolag commented Sep 17, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@nolag nolag force-pushed the rtinianov_delegateWorkflowSpec branch from b581fa6 to 99206f6 Compare September 17, 2024 13:59
@nolag nolag force-pushed the rtinianov_wasmDelegate branch 3 times, most recently from d2b7b4c to a6ee8f6 Compare September 17, 2024 14:29
Base automatically changed from rtinianov_delegateWorkflowSpec to develop September 17, 2024 20:03
@nolag nolag marked this pull request as ready for review September 18, 2024 15:57
@nolag nolag requested review from a team, eutopian and yevshev as code owners September 18, 2024 15:57
@nolag nolag requested review from krehermann and removed request for a team September 18, 2024 15:57
@nolag nolag requested a review from jmank88 September 20, 2024 14:57
DeividasK
DeividasK previously approved these changes Sep 25, 2024
View reviewed changes
@nolag nolag added this pull request to the merge queue Sep 25, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
67.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@nolag nolag added this pull request to the merge queue Sep 25, 2024
Merged via the queue into develop with commit 02982e3 Sep 25, 2024
124 of 127 checks passed
@nolag nolag deleted the rtinianov_wasmDelegate branch September 25, 2024 16:00
rafaelfelix added a commit that referenced this pull request Sep 26, 2024
@rafaelfelix
Revert "Add wasm spec factory (#14458)"
542f9d9 
This reverts commit 02982e3.
@rafaelfelix rafaelfelix mentioned this pull request Sep 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 26, 2024
@rafaelfelix
Revert "Add wasm spec factory (#14458)" (#14569)
207b0d5 
This reverts commit 02982e3.
HenryNguyen5 added a commit that referenced this pull request Sep 27, 2024
@HenryNguyen5
Reapply "Add wasm spec factory (#14458)" (#14569)
e6dd9f4 
This reverts commit 207b0d5.
@HenryNguyen5 HenryNguyen5 mentioned this pull request Sep 27, 2024
Merged
HenryNguyen5 added a commit that referenced this pull request Sep 28, 2024
@HenryNguyen5
Reapply "Add wasm spec factory (#14458)" (#14569)
7dc65d0 
This reverts commit 207b0d5.
HenryNguyen5 added a commit that referenced this pull request Oct 1, 2024
@HenryNguyen5
Reapply "Add wasm spec factory (#14458)" (#14569)
7189048 
This reverts commit 207b0d5.
nolag added a commit that referenced this pull request Oct 8, 2024
@nolag
Add wasm spec factory (#14458)
4096381 
* Add wasm spec factory

* Fix workflow tests

* Fix and test spec validation for non-YAML specs

* Revert use of logger in validate

* tidy and reorder inputs

* brotli the WASM so it's smaller for the sdk to pass around

* Fix so sum is always based on wasm not encoded value

* Fix typo and lint imports in wasm file spec factory

* Fix sha sum on wasm

* Fix go mod merge conflict :(

* Fix lint and remove local hack for go version...
github-merge-queue bot pushed a commit that referenced this pull request Oct 8, 2024
@nolag
Roll forward add wasm spec factory (#14458) (#14687)
910e65f 
* Add wasm spec factory (#14458)

* Add wasm spec factory

* Fix workflow tests

* Fix and test spec validation for non-YAML specs

* Revert use of logger in validate

* tidy and reorder inputs

* brotli the WASM so it's smaller for the sdk to pass around

* Fix so sum is always based on wasm not encoded value

* Fix typo and lint imports in wasm file spec factory

* Fix sha sum on wasm

* Fix go mod merge conflict :(

* Fix lint and remove local hack for go version...

* update permissiond on test file for lint

* Add toml name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@DeividasK DeividasK DeividasK approved these changes

@jmank88 jmank88 jmank88 approved these changes

@eutopian eutopian Awaiting requested review from eutopian

@yevshev yevshev Awaiting requested review from yevshev

@krehermann krehermann Awaiting requested review from krehermann krehermann is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nolag @jmank88 @DeividasK @cedric-cordenier