-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the comment on glyco-searching and the search summary on the result file #2367
Open
RayMSMS
wants to merge
23
commits into
smith-chem-wisc:master
Choose a base branch
from
RayMSMS:glyco-search-comment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2367 +/- ##
==========================================
+ Coverage 92.97% 93.73% +0.75%
==========================================
Files 139 139
Lines 21668 21704 +36
Branches 2983 3001 +18
==========================================
+ Hits 20146 20344 +198
+ Misses 1043 903 -140
+ Partials 479 457 -22
|
…Psms, Level1-glycoPsms) into the "AllResult.txt" file for glycoSearch (1) adding text function in PostGlycoSearchAnalysisTask class (2) adding tester in TestOGlyco class (make sure we parse the certain value) (3) revise the "readCsv", enable to read the allPSMs file smoothly.
nbollis
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…aMorpheus into glyco-search-comment
We also allow to get the same PSMs in duplicated files.
Alexander-Sol
approved these changes
Jun 13, 2024
(1) Rewrite the Summary writing function (2)Add the <summary> comment in the fuction header
…aMorpheus into glyco-search-comment
1. add new tester model for "OGlycanCompositionFragments"
1. add the tester for writing function, in different search type 2. glycoBox tester for decoy glycanBox
1. delete the bin and retry to pass the tester
deleted the duplicate tester
elaboy
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lei's comment on the coding of o-pair searching.
Try to add the search summary information (PSMs, protein group, glycoPsms, Level1-glycoPsms) into the "AllResult.txt" file for glycoSearch
(1) Text function in PostGlycoSearchAnalysisTask class
(2) Tester in TestOGlyco class (make sure we parse the certain value)
(3) revise the "readCsv", and enable it to read the allPSMs file smoothly.