Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for new source column in statements table #913

Merged
merged 2 commits into from
Aug 28, 2024
Merged

feat: add support for new source column in statements table #913

merged 2 commits into from
Aug 28, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Aug 22, 2024 •
edited
Loading

Toward https://github.com/snapshot-labs/workflow/issues/167

Add support for the new source column in the statements table

  • Add ability to query statements by source (string and array)
  • Can return source in Statement
  • Update schema.sql to reflect new source column

Note

To be merged after snapshot-labs/snapshot-sequencer#422

@wa0x6e wa0x6e requested a review from ChaituVR August 22, 2024 14:08
@wa0x6e wa0x6e mentioned this pull request Aug 22, 2024
Merged
1 task
bonustrack
bonustrack approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ChaituVR ChaituVR merged commit 5523a48 into master Aug 28, 2024
2 checks passed
@ChaituVR ChaituVR deleted the feat-return-source-from-statement branch August 28, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@ChaituVR ChaituVR Awaiting requested review from ChaituVR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wa0x6e @bonustrack @ChaituVR