Schema update: add aliased to space settings for voting and proposals #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@zzuziak It's better to use a single parameter for both vote and proposal actions, we can have the param inside space.voting |
bonustrack
approved these changes
Oct 24, 2022
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes 2844 for Snapshot.
Background
Currently the actions of creating a new proposal and casting a vote require a signature each time. The goal is to add new space setting enabling using the alias.
A sister PR on snapshot repo will implement the logic in the front end, this one updates the schema for spaces.
Changes proposed in this pull request:
aliased: booleantospace.voting