Space settings: use alias for vote and proposal

[zzuziak]

Fixes Issue #2844

Background

Currently voting and creating new proposals requires a signature each time. The goal of this PR is to add space setting enabling using the alias for both actions (one setting enables both).

Related PRs

• snapshot.js
• snapshot-hub

Changes in this PR:

• update interfaces and queries with new aliased field for spaces.filters and spaces.voting
• add inputs and locale for aliased proposal and voting
• check alias and pass alias data in useClient composable if space settings are enabled

Screenshots & Rec

Voting setting (currently in voting section, doesn't mention proposals):

Voting without alias:

Aliased proposal & vote:

How to test and review this PR?

1. Go to fabien.eth settings and enable aliased voting (requires merging two PRs mentioned above)
2. Create a new proposal for the space - if you have connected your wallet, there shouldn't be a request for signature
3. New proposal should be created
4. Vote on proposal - shouldn't get a request for signature and vote should go through ✔️

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
snapshot	✅ Ready (Inspect)	Visit Preview	Nov 11, 2022 at 9:20PM (UTC)

[bonustrack]

@zzuziak Just a quick comment, on this repo (and most of our repo) we use Yarn, this PR shouldn't have a package-lock.json file

[zzuziak]

Hey @bonustrack, thanks 🙏 I was trying to fetch this branch with npm as a dependency to test it, must have generated the file then.

I can't test the new schema updated on two branches (snapshot.js and hub) - what's your approach to test the repos together before merging PRs?

[zzuziak]

Updated with a single param for space.voting, currently the setting lies within the SettingsVotingBlock:

To make it more readable I can move it to an individual block and mention that it also allows aliased proposal creation.

[bonustrack]

@zzuziak You can use yarn link to get Snapshot.js in the UI. To test the whole flow you would need to run the hub locally but I recommend focus on the UI integration, we will do some change on the hub to get settings with the new aliased param accepted

[zzuziak]

Ok, ready for first review 👌

I didn't use aliasing for the usePersonalSign, I assumed Gnosis should always require the signature but correct me if I wrong, still digging into it 🙈

[samuveth]

We should allow alias actions only for these actions: "proposal", "vote" and "delete-proposal"

I think we have a miss understanding, I was referring to this comment from Fabien. I don't see this handled anywhere in your update.

In the current implementation in this PR it will also try to update settings with alias

[zzuziak]

I think we have a miss understanding, I was referring to this comment from Fabien. I don't see this handled anywhere in your update.

In the current implementation in this PR it will also try to update settings with alias

@samuveth I tagged you in the comments to clarify, let me know if it's still confusing 🙏

[zzuziak]

Hey @samuveth could you have a look at this PR again and see if there is something left to be done?

[samuveth]

@zzuziak yes, there are things to be done outside of this PR first and the useClient code need to be updated since we have depreciated personal sign since this PR was made. I'll take care of it from here and I'll assign it to myself.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.