Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space settings: use alias for vote and proposal #3265
Space settings: use alias for vote and proposal #3265
Changes from 12 commits
a957140
e72a344
4becf9b
e89dc39
b3789ee
94de30c
1b95acc
0a5fff8
e4ac5bc
93eb8f5
b2498bb
b12dd41
57dbcd4
fccf201
c30815e
92ea422
9f9308c
ead6e31
b8f1053
90a905a
fd64496
1e84da3
dffb9df
d1b0de6
7e661d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here for settings, without alias 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuveth here for settings I don't use
provider
andaddress
but force the auth viaweb3
, so even ifaliased === true
settings update will require a signature 🙏There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, that's pretty easy to miss, I was expecting a condition where you set the
provider
andaddress
at the topThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to suggest a more readable solution! 🙏 The conditional is defined above, but I just don't use it for the settings action.