refactor: explicit invalidations for native and cpp #6850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
commented
Dec 24, 2024
| explicit WorkletsModule( | ||
| jni::alias_ref<WorkletsModule::jhybridobject> jThis, |
There was a problem hiding this comment.
Turns out we don't need to keep the reference to Java part of WorkletsModule in cpp.
tjzel
commented
Dec 24, 2024
| assertWithMessage( | ||
| instanceCount_ <= 1, | ||
| instanceCount_ < 1, |
There was a problem hiding this comment.
When cleaning during invalidation stage, it shouldn't be possible for two instances to exist at the same time.
tjzel
added
the
Check compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull requests refactors memory management of Worklets and Reanimated.
Basically, since Reanimated can obtain WorkletsModuleProxy and the Worklet Runtimes as shared pointers, it has to release them explicitly during the invalidation stage of Native Modules. Releasing them later on (e.g. via deconstructors) might lead into issues and crashes.
Ideally we'd instead use some different solution here than shared pointers, but it can wait as it's not mandatory at the moment and could be a significant refactor.
Fixes:
Test plan