rustfmt: use nightly in CI #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Nov 7, 2023
buffalojoec
force-pushed
the
11-07-rustfmt_use_entrypoint_full_path
branch
from
d5ada93
to
f3941d6
Compare
buffalojoec
force-pushed
the
11-07-rustfmt_use_nightly_in_CI
branch
2 times, most recently
from
54ee72c
to
7f69f0d
Compare
joncinque
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Along with this change, can you add a cargo-nightly script similar to the cargo script in the monorepo? It literally just needs to do:
#!/usr/bin/env bash
here=$(dirname "$0")
source "${here}"/ci/rust-version.sh nightly
# shellcheck disable=SC2054 # rust_nightly is sourced from rust-version.sh
toolchain="$rust_nightly"
set -x
exec cargo "+${toolchain}" "${@}"
This will make it easier to run fmt or clippy since you can just call ./cargo-nightly fmt or whatever. I've long used shell history to know the right nightly version to use, but a helper script will be good for other devs too. What do you think?
buffalojoec
force-pushed
the
11-07-rustfmt_use_entrypoint_full_path
branch
from
f3941d6
to
173e279
Compare
buffalojoec
force-pushed
the
11-07-rustfmt_use_nightly_in_CI
branch
from
f18fead
to
3a1ae53
Compare
Merge activity
|
Base automatically changed from
11-07-rustfmt_use_entrypoint_full_path
to
master
November 8, 2023 20:36
buffalojoec
force-pushed
the
11-07-rustfmt_use_nightly_in_CI
branch
from
3a1ae53
to
266bc51
Compare
mergify
bot
dismissed
joncinque’s stale review
Pull request has been modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR opts for using the
nightlychannel in CI forrustfmt.