Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt: format imports #5743

Merged
merged 1 commit into from
Nov 8, 2023
Merged

rustfmt: format imports #5743

merged 1 commit into from
Nov 8, 2023

Conversation

buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented Nov 7, 2023

This PR adds import formatting configurations to the repository's rustfmt.toml file, and the associated changes from cargo +nightly fmt --all.

Copy link
Contributor Author

buffalojoec commented Nov 7, 2023

@buffalojoec buffalojoec force-pushed the 11-07-rustfmt_use_nightly_in_CI branch from f4e596d to 54ee72c Compare November 7, 2023 11:14
@buffalojoec buffalojoec force-pushed the 11-07-rustfmt_use_nightly_in_CI branch from 54ee72c to 7f69f0d Compare November 7, 2023 11:31
@buffalojoec buffalojoec force-pushed the 11-07-rustfmt_format_imports branch 3 times, most recently from f1571f5 to 88907a4 Compare November 7, 2023 12:36
@buffalojoec
Copy link
Contributor Author

buffalojoec commented Nov 7, 2023

heh, this one is huge 😅

@joncinque CI is passing, but if we want to break this one up I can maybe wait to add the file and instead just format a few crates at a time manually with in-line configs.

I could also do this via commits within this PR. Lmk

joncinque
joncinque previously approved these changes Nov 7, 2023
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overwhelmed

Nah no worries, we can merge this as is, looks great! Just be careful, now your name will be all over the repo 😉

@buffalojoec buffalojoec marked this pull request as ready for review November 7, 2023 14:15
@buffalojoec buffalojoec force-pushed the 11-07-rustfmt_use_nightly_in_CI branch from f18fead to 3a1ae53 Compare November 8, 2023 10:32
Copy link
Contributor Author

buffalojoec commented Nov 8, 2023

Merge activity

@buffalojoec buffalojoec force-pushed the 11-07-rustfmt_use_nightly_in_CI branch from 3a1ae53 to 266bc51 Compare November 8, 2023 20:36
Base automatically changed from 11-07-rustfmt_use_nightly_in_CI to master November 8, 2023 20:37
@mergify mergify bot dismissed joncinque’s stale review November 8, 2023 20:38

Pull request has been modified.

@buffalojoec buffalojoec merged commit e82d923 into master Nov 8, 2023
35 checks passed
@buffalojoec buffalojoec deleted the 11-07-rustfmt_format_imports branch November 8, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants