Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto-populate page field when reporting an issue #1051

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open
Changes from 5 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
0743679
fix: Make "Report an issue" link open in new tab
bertday Jan 30, 2025
69a3f9a
chore: Clean up whitespace in page-issue-link classes
bertday Jan 30, 2025
bf08606
feat: Auto-populate page field when reporting an issue
bertday Jan 30, 2025
10124c2
Merge branch 'main' into iss-1049
kodiakhq[bot] Jan 30, 2025
059f2e5
Merge branch 'main' into iss-1049
kodiakhq[bot] Jan 30, 2025
be72882
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 6, 2025
1fada80
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 6, 2025
4e23f90
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 7, 2025
b77828b
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 7, 2025
740b7c8
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 7, 2025
71008c6
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 7, 2025
e209677
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 10, 2025
e4eaed9
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 13, 2025
8763095
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 13, 2025
da20136
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 13, 2025
f135ca3
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 13, 2025
ca19dd5
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 16, 2025
0ba2e65
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 16, 2025
6c6c386
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 16, 2025
49717c7
docs: resolve formatting issue in page-issue-link
bertday Feb 16, 2025
691905c
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 18, 2025
4333236
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 18, 2025
793707c
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 18, 2025
0335938
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 18, 2025
38925ae
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 18, 2025
7a8de23
docs: use backticks in page-issue-link
bertday Feb 18, 2025
bf27057
Update src/ui/page-issue-link.tsx
bertday Feb 18, 2025
5e6e2c6
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 18, 2025
daa1ce1
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 18, 2025
a42d7b4
Merge branch 'main' into iss-1049
kodiakhq[bot] Feb 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/ui/page-issue-link.tsx
Original file line number Diff line number Diff line change
@@ -8,7 +8,14 @@
const i18n = useI18n();

const srcPath = createMemo(() => {
return `https://github.com/solidjs/solid-docs-next/issues/new?assignees=ladybluenotes&labels=improve+documentation%2Cpending+review&projects=&template=CONTENT.yml&title=[Content]:&subject=${getEntryFileName()}`;
return `https://github.com/solidjs/solid-docs-next/issues/new` +

Check failure on line 11 in src/ui/page-issue-link.tsx

GitHub Actions / lint

Strings must use doublequote
`?assignees=ladybluenotes` +

Check failure on line 12 in src/ui/page-issue-link.tsx

GitHub Actions / lint

Strings must use doublequote
`&labels=improve+documentation%2Cpending+review` +

Check failure on line 13 in src/ui/page-issue-link.tsx

GitHub Actions / lint

Strings must use doublequote
`&projects=` +

Check failure on line 14 in src/ui/page-issue-link.tsx

GitHub Actions / lint

Strings must use doublequote
`&template=CONTENT.yml` +

Check failure on line 15 in src/ui/page-issue-link.tsx

GitHub Actions / lint

Strings must use doublequote
`&title=[Content]:` +

Check failure on line 16 in src/ui/page-issue-link.tsx

GitHub Actions / lint

Strings must use doublequote
`&subject=${getEntryFileName()}` +
`&page=${window.location.href}`

Check warning on line 18 in src/ui/page-issue-link.tsx

GitHub Actions / lint

Missing semicolon
});
Copy link
Collaborator

@amirhhashemi amirhhashemi Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bertday A formatting issue is blocking this PR. Could you please format the file or use the following code:

		return (
			"https://github.com/solidjs/solid-docs-next/issues/new" +
			"?assignees=ladybluenotes" +
			"&labels=improve+documentation%2Cpending+review" +
			"&projects=" +
			"&template=CONTENT.yml" +
			"&title=[Content]:" +
			"&subject=${getEntryFileName()}" +
			"&page=${window.location.href}"
		);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amirhhashemi , this should be resolved now!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bertday My bad, I should've used ` instead of " for strings. I didn't notice template strings are required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amirhhashemi , just pushed a change to bring this backticks back. Really hoping this does this trick.

return (
<a