Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setter type compatibility with kobalte select and add tests #2318

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

Huliiiiii
Copy link
Contributor

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 14237a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Huliiiiii Huliiiiii changed the title Fix type compatibility with kobalte select and add a test Fix type compatibility with kobalte select and add tests Oct 1, 2024
@coveralls
Copy link

coveralls commented Oct 1, 2024

Pull Request Test Coverage Report for Build 11225671818

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.357%

Totals Coverage Status
Change from base Build 11024867206: 0.0%
Covered Lines: 4205
Relevant Lines: 4438

💛 - Coveralls

@Huliiiiii Huliiiiii changed the title Fix type compatibility with kobalte select and add tests Fix setter type compatibility with kobalte select and add tests Oct 1, 2024
@ryansolid ryansolid merged commit e2e2a03 into solidjs:main Oct 7, 2024
1 check passed
@ryansolid
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants