Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving VHO tests in an attempt to investigate a bug #10385

Merged
merged 25 commits into from
Nov 26, 2024

Conversation

ryanrolds
Copy link

@ryanrolds ryanrolds commented Nov 21, 2024

Description

  • Changed the header names because the test output showed Nginx responding with X-Transfer-Encoding: chunked, which means Content-Length was never on the response
  • Order the steps in each test to more strongly assert that conflict resolution and merging didn't affect earlier applied resources
  • Moved the curl check at the end so that it's asserting against a confirmed desired state
  • Renamed some things to better clarify what is happening in the test
  • Removed the manifest list and added cleanup callback to give each finer grained and a clear picture of the test

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@ryanrolds ryanrolds changed the title Improving VHO tests in an attempt to investigate a bug [DRAFT] Improving VHO tests in an attempt to investigate a bug Nov 21, 2024
@ryanrolds ryanrolds marked this pull request as ready for review November 21, 2024 01:02
@solo-changelog-bot
Copy link

Issues linked to changelog:
k8sgateway#10310

@ryanrolds ryanrolds changed the title [DRAFT] Improving VHO tests in an attempt to investigate a bug Improving VHO tests in an attempt to investigate a bug Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

Visit the preview URL for this PR (updated for commit 2549794):

https://gloo-edge--pr10385-rolds-cleanup-vhost-925mhr24.web.app

(expires Tue, 03 Dec 2024 19:23:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

Copy link

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually the changes look good to me! I'd like to run them locally to better understand them, but leaving an approval as I think this is good to merge

Comment on lines 85 to 86
matchers.ContainHeaderKeys([]string{"x-bar"}),
matchers.ContainHeaderKeys([]string{"x-baz"}),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Since the ContainHeaderKeys matcher supports a list, any reason we don't combine these into a single assertion?

@ryanrolds ryanrolds merged commit 538482d into main Nov 26, 2024
19 checks passed
@ryanrolds ryanrolds deleted the rolds/cleanup_vhost_opts_suite branch November 26, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants