-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving VHO tests in an attempt to investigate a bug #10385
Conversation
Issues linked to changelog: |
…o-io/gloo into rolds/cleanup_vhost_opts_suite
…o-io/gloo into rolds/cleanup_vhost_opts_suite
Visit the preview URL for this PR (updated for commit 2549794): https://gloo-edge--pr10385-rolds-cleanup-vhost-925mhr24.web.app (expires Tue, 03 Dec 2024 19:23:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptually the changes look good to me! I'd like to run them locally to better understand them, but leaving an approval as I think this is good to merge
matchers.ContainHeaderKeys([]string{"x-bar"}), | ||
matchers.ContainHeaderKeys([]string{"x-baz"}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Since the ContainHeaderKeys matcher supports a list, any reason we don't combine these into a single assertion?
Description
X-Transfer-Encoding: chunked
, which meansContent-Length
was never on the responseChecklist: