forked from k8sgateway/k8sgateway
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving VHO tests in an attempt to investigate a bug #10385
Merged
Merged
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
b3771ca
Improving tests in an attempt to better expose the underlying bug
ryanrolds 80fb3e2
Comments and renamed a function
ryanrolds f675dde
Test adjustments
ryanrolds 2788f08
Added changelog
ryanrolds 442e488
Moved changelog
ryanrolds d07708f
Fixing issue with test failure
ryanrolds c4a1aac
Merge branch 'main' into rolds/cleanup_vhost_opts_suite
ryanrolds 87f1c4c
Adjusting how I'm applying a resource that is expected to fail
ryanrolds 7dd22dd
Merge branch 'rolds/cleanup_vhost_opts_suite' of ssh://github.com/sol…
ryanrolds f985e4b
Merge branch 'main' into rolds/cleanup_vhost_opts_suite
ryanrolds cf6ad8c
Merge branch 'main' into rolds/cleanup_vhost_opts_suite
ryanrolds e8d06e2
Trying to address issue with rejection test
ryanrolds f063979
Merge branch 'rolds/cleanup_vhost_opts_suite' of ssh://github.com/sol…
ryanrolds c70d642
Fixed issue with checking wrong resource is deleted
ryanrolds 46745ee
Merge branch 'main' into rolds/cleanup_vhost_opts_suite
ryanrolds 7b072bc
Merge branch 'main' into rolds/cleanup_vhost_opts_suite
nfuden 1cef969
Merge branch 'main' into rolds/cleanup_vhost_opts_suite
ryanrolds a9e3343
Adding changelog file to new location
a22f7d6
Deleting changelog file from old location
7d6a543
Merge branch 'main' into rolds/cleanup_vhost_opts_suite
ryanrolds 9f78bc7
Merge branch 'main' into rolds/cleanup_vhost_opts_suite
ryanrolds 7d8598b
Merge branch 'main' into rolds/cleanup_vhost_opts_suite
ryanrolds 2b93f93
Merge branch 'main' into rolds/cleanup_vhost_opts_suite
ryanrolds fb62a25
Merged assertions
ryanrolds 2549794
Merge branch 'main' into rolds/cleanup_vhost_opts_suite
ryanrolds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
changelog: | ||
- type: NON_USER_FACING | ||
description: | | ||
Strengthed VHO kubernetes/e2e tests. Addressed issue with checking for `content-length` | ||
header in response containing `transfer-encoding: chunked` header. | ||
Added to confirm previously conflicting VHO being accepted after blocker is deleted. | ||
issueLink: https://github.com/k8sgateway/k8sgateway/issues/10310 | ||
resolvesIssue: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Since the ContainHeaderKeys matcher supports a list, any reason we don't combine these into a single assertion?