Start scripts without ./bin and .sh, config mount at /etc/kafka #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Explains the log4j.properties gotcha quite well: https://stackoverflow.com/questions/43823833/kafka-with-server-properties-not-picking-log4j |
solsson
added a commit
to Yolean/kubernetes-kafka
that referenced
this pull request
Jul 26, 2017
you must use /opt/kafka/config, due to how log4j.properites (sometimes tools- or connect-) are resolved by the ./bin scripts. See solsson/dockerfiles#10
This was referenced Jul 26, 2017
solsson
force-pushed
the
workdir-agnostic-bin
branch
from
9fe838d
to
67b5dea
Compare
solsson
added a commit
to Yolean/kubernetes-kafka
that referenced
this pull request
Jul 26, 2017
to not mix with sample config. See solsson/dockerfiles#10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by the Confluent Platform images. Without this change, users of the image would settle for the
./binand./configconventions. Mounted config would sit at /opt/kafka/config or chose a path such as/etc/kafkaAND setKAFKA_LOG4J_OPTSto for example-D/etc/kafka/log4j.properties.This fix will not use any additional space if we restore the symlinks from before 72b35da and move the RUN into the kafka installation step.