[TWAMP] Add TWAMP Light feature HLD #1320

huseratgithub · 2023-04-10T13:18:19Z

This document provides general information about the TWAMP Light feature implementation in SONiC.
This feature has been tracked in #1192

Repo	PR title	State
sonic-swss	TWAMP Light orchagent implementation
sonic-swss-common	Added TWAMP Light table to schema
sonic-sairedis	Support TWAMP Light notification in syncd
sonic-utilities	Added CLIs to support TWAMP Light
SAI	Added TWAMP Light API

Signed-off-by: Xiaodong Hu <[email protected]>

zhangyanzhao · 2023-06-08T00:32:36Z

@huseratgithub can you please update the HLD by using community HLD template https://github.com/sonic-net/SONiC/blob/master/doc/hld_template.md, there are mandatory sections to cover. Thanks.

huseratgithub · 2023-06-08T01:52:28Z

#1320 (comment)
@zhangyanzhao upding and will submit in the weekend

huseratgithub · 2023-06-08T01:53:00Z

huseratgithub · 2023-06-10T12:57:43Z

@huseratgithub can you please update the HLD by using community HLD template https://github.com/sonic-net/SONiC/blob/master/doc/hld_template.md, there are mandatory sections to cover. Thanks.

@zhangyanzhao I have update the HLD by template, please help to check and review, thanks

Signed-off-by: huxd <[email protected]>

zhangyanzhao · 2023-06-13T15:02:50Z

community review recording https://zoom.us/rec/share/KMpGzdM5XUr3cfO7jfIWmgtgONfyYKA_FZXK_nIB_jZFWj2GtodlReuVH73W0tNs.K32lR8TWbGckHUFO

zhangyanzhao · 2023-06-13T15:57:28Z

This is reviewed in SONiC community. Please let me know if you want to be reviewer for this feature, thanks.

Signed-off-by: huxd <[email protected]>

huseratgithub · 2023-06-21T10:01:29Z

Answer questions raised during the review meeting:

How do you detemine HW or SW TWAMP solution? >> detemined based on ASIC capability
At phase 1, it is based on the ASIC capability. Twamporch can query the TWAMP Light capability through SAI API during system initialization.
Do you have CoPP configuration support for SW base TWAMP solution? >> No
No, we will add a new trap for SW solution which is considered in phase 2.
In SONiC, In HW based mechanism - all the counter are update through flex counters before it updates counters db. Does the design follow the same mechanism?
No, ASIC will actively report the measuement data at the end of statistical period. The benefit is that the performance measuement data can be reported in time and the software does not need to synchronize the statistical cycle with the hardware.
Can this TWAMP polling interval be configurable? How can it be done - let's update the HLD section
Yes, when creating a TWAMP Light session, configure it with the parameter statistics_interval. Polling interval is responsible to the frequency for updating counters db. It is described in configuration commands section.
Who will be the consumers for TWAMP session updated in the State_DB? >> Can you share some reference applications of interest/consumption in this state?
Show command reads the twamp session state from STATE_DB. The state indicates the TWAMP Light session running state.
Since this feature has dependency with ASIC support, let's control this feature controller at complile time flag? Ex: sflow
Ok, we will add a compilation flag to control the compilation of TWAMP Light feature.
Can you share a few reference sample use cases which support TWAMP feature?
High latency, jitter and packet loss, and an aggravating user experience are just a few of the issues to be expected when links are not performing as expected or have been configured incorrectly.
How do you trap the TWAMP session to CPU? Do you have COPP rules enforced or not? Let's mention HLD in detail.
ACL entry with TWAMP-Test packet filed such as ip, udp_port will be installed to ASIC when creating a TWAMP Light session. Also we will add a new trap of host interface for TWAMP-Test packet, and this trap can be used in COPP rules.
Let's have a CLI or user control HW/SW based TWAMP solutions? Ex: if HW solution doesn't need a SW TWAMP container at all.
OK, we will add a new CLI to decide to use HW or SW solution in phase 2.
How are you offloading the TWAMP session to hardware? doesn't it use an APP DB?
It does not use an APP_DB, because we think all TWAMP Light session attributes can be configured in CONFIG_DB by CLI, and we want the TWAMP Light module to remain independent.
Does support configure a wide range interval for TWAMP counters.
We will add a wide range interval for TWAMP Light counters.

community review recording https://zoom.us/rec/share/KMpGzdM5XUr3cfO7jfIWmgtgONfyYKA_FZXK_nIB_jZFWj2GtodlReuVH73W0tNs.K32lR8TWbGckHUFO

guxianghong · 2023-07-13T05:55:54Z

@zhangyanzhao We have invite @clarklee-guizhao to reivew this PR,
Could you please help to add @clarklee-guizhao into the reviewer list, Thanks very much.

huseratgithub · 2023-10-11T06:21:54Z

@zhangyanzhao @yxieca The comments were handled. can you please help to approve/merge?

zhangyanzhao · 2023-10-11T06:50:32Z

Can you please help to add the code PR into this HLD by referring to #806 ? That is required before merging this HLD PR. Thanks.

huseratgithub · 2023-10-12T09:03:38Z

Can you please help to add the code PR into this HLD by referring to #806 ? That is required before merging this HLD PR. Thanks.

The code PRs have been added. Could you please help to review/merge? Thanks

clarklee-guizhao

LGTM

huseratgithub · 2023-10-24T12:34:24Z

@zhangyanzhao @yxieca Could you please help to approve/merge? Thanks.

huseratgithub · 2023-10-25T05:41:47Z

@clarklee-guizhao Thanks a lot for your review.

[schema][twamp] Add twamp light table to schema [TWAMP] Add TWAMP Light feature HLD sonic-net/SONiC#1320

zhangyanzhao · 2024-02-05T07:01:08Z

reviewer approved and merge

prsunny · 2024-02-08T02:21:39Z

@huseratgithub , where is the sonic-mgmt test for this feature?

huseratgithub · 2024-02-23T02:09:21Z

@huseratgithub , where is the sonic-mgmt test for this feature?

hi @prsunny , sonic-mgmt is an enhancement, let's have it in later phase.

* [orchagent] TWAMP Light orchagent implementation. (#2927) * What I did Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net/SONiC#1320).

* [orchagent] TWAMP Light orchagent implementation. (sonic-net#2927) * What I did Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net/SONiC#1320).

* Fixes mock test failure * Fixes mock test run failure fixes pipeline run failure FAIL: p4orch_tests_usan ======================= ../../../orchagent/vrforch.cpp:113:41: runtime error: member call on null pointer of type 'struct RouteOrch' ../../../orchagent/vrforch.cpp:113:41: runtime error: member access within null pointer of type 'struct RouteOrch' FAIL p4orch_tests_usan (exit status: 139) * Fixed orchagent crash in VM with the Qos BUFFER_QUEUE|system-port|Queue-id-range config (sonic-net#3050) * Fixed orchagent crash in VM with the Qos BUFFER_QUEUE|system-port|Queue-id-range config * [intfsorch] Enable ipv6 proxy ndp along with proxy arp (sonic-net#3045) * [intfsorch] Enable ipv6 proxy ndp along with proxy arp setting SAI_VLAN_ATTR_UNKNOWN_MULTICAST_FLOOD_CONTROL_TYPE to SAI_VLAN_FLOOD_CONTROL_TYPE_NONE when proxy arp is enabled. This fixes a bug where ipv6 NS packets were flooding ports with duplicate packets. We now set multicast flood type to none. * Fix multi VLAN neighbor learning (sonic-net#3049) What I did When adding a new neighbor, check if the neighbor IP has already been learned on a different VLAN. If it has, remove the old neighbor entry before adding the new one. Why I did it On Gemini devices, if a neighbor IP moves from an active port in one VLAN to a second VLAN, then back to the first VLAN (with 3 different MAC addresses), orchagent will crash. Even though the MAC address of the last move is different from the first MAC address, orchagent believes the last MAC address to already be programmed in the hardware and tries to set an attribute of the entry which doesn't exist. * [asan] Disable the "maybe-uninitialized" warning when compiled with ASAN enabled. * Set HOST_TX_READY_NOTIFY attribute only after query capabilities(sonic-net#3070) *Set HOST_TX_READY_NOTIFY attribute only after query capabilities * [EVPN] Skip EVPN routes with invalid VNI or router mac field (sonic-net#3073) * Skip EVPN routes with invalid VNI or router mac field * Add port flap count and last flap timestamp to APPL_DB (sonic-net#3052) * Add port flap count and last flap timestamp * Add basic fabric link monitoring counters and states handling. (sonic-net#2988) * Add basic fabric link monitoring counters and states handling. * [Mellanox] Fix inconsistence in the shared headroom pool initialization (sonic-net#3057) * Fix inconsistence in the shared headroom pool initialization * Why I did it During initialization, if SHP is enabled the buffer pool sizes, xoff have initialized to 0, which means SHP is disabled but the buffer profiles already indicate SHP later on the buffer pool sizes are updated with off being non-zero In case the orchagent starts handling buffer configuration between 2 and 3, it is inconsistent between buffer pools and profiles, which fails Mellanox SAI sanity check. To avoid it, it indicates SHP enabled by setting a very small buffer pool and SHP sizes * [acl] Add IN_PORTS qualifier for L3 table (sonic-net#3078) * Apply IN_PORTS qualifiier for L3 table Why I did it IN_PORTS qualifier was allowed for L3 table in 202012 release and below. Changes in sonic-net#1982 removed that support leading to regression in some of our testcases. The following error was observed ERR swss#orchagent: :- validateAclRuleMatch: Match SAI_ACL_ENTRY_ATTR_FIELD_IN_PORTS in rule RULE_1 is not supported by table DATAACL * [bulker] add support for neighbor bulking (sonic-net#2768) Adding support for sai_neighbor_api_t bulking in bulker.h * [buffermgrd] Move switch-statement outside of if-statement in BufferMgr::doTask (sonic-net#3055) * [buffermgr] Moved switch statement outside of if-statmement in Buffermgr::doTask The switch statement which would normally erase buffer events was moved to be inside the if-statement which would only enter if the event is a SET event. This was introduced in commit e5329c39. This would cause an infinite loop, since non-set events would never be erased. The switch statement has now been moved to occur outside the if, allowing for non-set commands to be processed. * [portsorch] process only updated APP_DB fields when port is already created (sonic-net#3025) * [portsorch] process only updated APP_DB fields when port is already created What I did Fixing an issue when setting some port attribute in APPL_DB triggers serdes parameters to be re-programmed with port toggling. Made portsorch to handle only those attributes that were pushed to APPL_DB, so that serdes programming happens only by xcvrd's request to do so. * [Copp]Refactor coppmgr tests (sonic-net#3093) What I did Refactoring coppmgr mock tests Why I did it After migration to bookworm, coppmgr tests started failing due to the use of sudo commands. * Revert "[acl] Add IN_PORTS qualifier for L3 table (sonic-net#3078)" (sonic-net#3092) This reverts commit 9d4a3ad. *Revert "[acl] Add IN_PORTS qualifier for L3 table" * [orchagent] TWAMP Light orchagent implementation (sonic-net#2927) * [orchagent] TWAMP Light orchagent implementation. (sonic-net#2927) * What I did Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net/SONiC#1320). * Clang format change. (sonic-net#3080) What I did This PR has no real code change. It is purely clang formatting. It only applies to the P4Orch codes. Commands that I run: find orchagent/p4orch -name *.h -o -name .cpp | xargs clang-format -i -style="{BasedOnStyle: Microsoft, DerivePointerAlignment: false}" find orchagent -name response_publisher -o -name return_code.h | xargs clang-format -i -style="{BasedOnStyle: Microsoft, DerivePointerAlignment: false}" * T2-VOQ-VS: Fix iBGP bringup issue (sonic-net#3053) * Fix iBGP bringup issue T2-vswitch * On T2-VOQ chassis Emulation with multi-asic linecards, iBGP sessions dont come up. Related Issue: sonic-net/sonic-buildimage#18129 * [Fdbsyncd] Adding extern_learn flag with fdb entry so Kernel doesn't age out (sonic-net#2985) * Adding extern_learn flag with fdb entry so that Kernel doesn't age out the MAC * [Fdbsyncd] Adding extern_learn flag with fdb entry so Kernel doesn't age out What I did extern_learn flag is added while programming the fdb entry into the Kernel. This will make sure that kernel doesn't age out the fdb entry. (#15004) How I did it A flag extern_learn will be passed while programing the fdb entry. (#15004) How to verify it Tested MAC add/del to the Kernel from the local FDB entry. (#15004) Signed-off-by: [email protected] --------- Signed-off-by: [email protected] Co-authored-by: Sudharsan Dhamal Gopalarathnam <[email protected]> * Fix oper FEC retrieval after warmboot (sonic-net#3100) Updating oper FEC status in state_db after warm-reboot as part of refresh port status call * [EVPN]Fix fpmsyncd crash when EVPN type5 is received with bgp fib suppression enabled (sonic-net#3101) * [EVPN]Fix fpmsyncd crash when EVPN type5 is received with bgp fib suppression enabled * [portsorch] Handle TRANSCEIVER_INFO table on warm boot (sonic-net#3087) * Add existing data from TRANSCEIVER_INFO table * Introduce a new role for DPU-NPU Interconnect Signed-off-by: Vivek Reddy Karri <[email protected]> Co-authored-by: Sudharsan Dhamal Gopalarathnam <[email protected]> * [p4orch] Clang format change. (sonic-net#3096) What I did [p4orch] This PR has no real code change. It is purely clang formatting. It does the same as sonic-net#3080. * [dash] fix ENI admin state update (sonic-net#3081) * [dash] fix ENI admin state update * Add force option for fabric port unisolate command (sonic-net#3089) What I did Add force option to the unisolate link command, so users can make the links not isolate if they want. depends on sonic-net/sonic-buildimage#18447 * [twamporch] Explicitly initialize local variable (sonic-net#3115) What I did Explicitly initialized local variable. Why I did it We met below error message in sonic-buildimage armhf build (sonic-net/sonic-buildimage#18334) * Add bookworm build to the PR checkers (sonic-net#3114) What I did Add a Bookworm build to the PR checkers. Also fix some Bookworm build errors that crept in. Why I did it Buildimage now builds swss for Bookworm, so the build needs to succeed. * [ACL] Remove flex counter when updating ACL rule (sonic-net#3118) What I did This PR is to fix sonic-net/sonic-buildimage#18719 When ACL rule is created for the first time, a flex counter is created and registered. When the same ACL rule is being updated, the FlexCounter created before is not removed, and another FlexCounter is created and registered. Why I did it Fix the issue that FlexCounter is duplicated when updating existing ACL rule. --------- Signed-off-by: [email protected] Signed-off-by: Vivek Reddy Karri <[email protected]> Co-authored-by: saksarav-nokia <[email protected]> Co-authored-by: Nikola Dancejic <[email protected]> Co-authored-by: Lawrence Lee <[email protected]> Co-authored-by: Oleksandr Ivantsiv <[email protected]> Co-authored-by: noaOrMlnx <[email protected]> Co-authored-by: Lior Avramov <[email protected]> Co-authored-by: Prince George <[email protected]> Co-authored-by: jfeng-arista <[email protected]> Co-authored-by: Stephen Sun <[email protected]> Co-authored-by: Neetha John <[email protected]> Co-authored-by: Amir <[email protected]> Co-authored-by: Stepan Blyshchak <[email protected]> Co-authored-by: Sudharsan Dhamal Gopalarathnam <[email protected]> Co-authored-by: xiaodong hu <[email protected]> Co-authored-by: mint570 <[email protected]> Co-authored-by: Deepak Singhal <[email protected]> Co-authored-by: KISHORE KUNAL <[email protected]> Co-authored-by: Vivek <[email protected]> Co-authored-by: Yakiv Huryk <[email protected]> Co-authored-by: Saikrishna Arcot <[email protected]> Co-authored-by: bingwang-ms <[email protected]>

zhangyanzhao · 2024-05-22T16:40:34Z

@eddieruan-alibaba can you please help to find someone in Alibaba to complete the code PR review? Thanks.

goomadao · 2024-05-23T06:10:12Z

Hi @huseratgithub , great feature for us. But do you have any plan about the software solution of TWAMP Light? There is few ASICs supporting the TWAMP offload ASAIK and we're considering to offload timestamping only to the ASIC.

guxianghong · 2024-06-01T06:40:09Z

Hi @huseratgithub , great feature for us. But do you have any plan about the software solution of TWAMP Light? There is few ASICs supporting the TWAMP offload ASAIK and we're considering to offload timestamping only to the ASIC.

Yes, after completing the phase1 hardware-based TWAMP light, we will immediately start the phase2 software-based TWAMP light which has already been condidered in the TWAMP light HLD.

zhangyanzhao · 2024-06-04T17:17:21Z

one code PR is still open, move to backlog

huseratgithub force-pushed the devpr_huxd_sonic-net_twamp_20230410 branch from e3b7fc8 to b7a2e5b Compare April 10, 2023 13:26

guxianghong mentioned this pull request Apr 10, 2023

Two-Way Active Measurement Protocol (TWAMP) Light #1192

Open

[TWAMP] Add TWAMP Light feature HLD

a86b85a

Signed-off-by: Xiaodong Hu <[email protected]>

guxianghong force-pushed the devpr_huxd_sonic-net_twamp_20230410 branch from b7a2e5b to a86b85a Compare May 18, 2023 09:38

guxianghong approved these changes May 19, 2023

View reviewed changes

huseratgithub closed this Jun 8, 2023

huseratgithub reopened this Jun 8, 2023

huseratgithub force-pushed the devpr_huxd_sonic-net_twamp_20230410 branch 2 times, most recently from 56402b3 to 14df416 Compare June 10, 2023 12:51

huseratgithub force-pushed the devpr_huxd_sonic-net_twamp_20230410 branch from 345d3cd to ce693d3 Compare June 13, 2023 01:42

[TWAMP] update TWAMP Light HLD by using community HLD template

d2dff4b

Signed-off-by: huxd <[email protected]>

huseratgithub force-pushed the devpr_huxd_sonic-net_twamp_20230410 branch from ce693d3 to d2dff4b Compare June 13, 2023 06:53

[TWAMP] Addressed community review comments

f25eed5

Signed-off-by: huxd <[email protected]>

zhangyanzhao requested a review from clarklee-guizhao October 11, 2023 06:48

guxianghong mentioned this pull request Oct 12, 2023

Add CLIs to support TWAMP Light sonic-net/sonic-utilities#3011

Open

clarklee-guizhao approved these changes Oct 24, 2023

View reviewed changes

guxianghong mentioned this pull request Oct 31, 2023

[TWAMP] Add twamp light table to schema sonic-net/sonic-swss-common#823

Merged

prsunny pushed a commit to sonic-net/sonic-swss-common that referenced this pull request Nov 17, 2023

[TWAMP] Add twamp light table to schema (#823)

05e024e

[schema][twamp] Add twamp light table to schema [TWAMP] Add TWAMP Light feature HLD sonic-net/SONiC#1320

zhangyanzhao merged commit 4abfa5f into sonic-net:master Feb 5, 2024

huseratgithub mentioned this pull request Feb 20, 2024

[orchagent] TWAMP Light orchagent implementation sonic-net/sonic-swss#2927

Merged

zhangyanzhao requested a review from eddieruan-alibaba May 22, 2024 16:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TWAMP] Add TWAMP Light feature HLD #1320

[TWAMP] Add TWAMP Light feature HLD #1320

huseratgithub commented Apr 10, 2023 •

edited

Loading

zhangyanzhao commented Jun 8, 2023

huseratgithub commented Jun 8, 2023

huseratgithub commented Jun 8, 2023

huseratgithub commented Jun 10, 2023

zhangyanzhao commented Jun 13, 2023

zhangyanzhao commented Jun 13, 2023

huseratgithub commented Jun 21, 2023 •

edited

Loading

guxianghong commented Jul 13, 2023

huseratgithub commented Oct 11, 2023

zhangyanzhao commented Oct 11, 2023

huseratgithub commented Oct 12, 2023 •

edited

Loading

clarklee-guizhao left a comment

huseratgithub commented Oct 24, 2023

huseratgithub commented Oct 25, 2023

zhangyanzhao commented Feb 5, 2024

prsunny commented Feb 8, 2024

huseratgithub commented Feb 23, 2024

zhangyanzhao commented May 22, 2024

goomadao commented May 23, 2024

guxianghong commented Jun 1, 2024

zhangyanzhao commented Jun 4, 2024

[TWAMP] Add TWAMP Light feature HLD #1320

[TWAMP] Add TWAMP Light feature HLD #1320

Conversation

huseratgithub commented Apr 10, 2023 • edited Loading

zhangyanzhao commented Jun 8, 2023

huseratgithub commented Jun 8, 2023

huseratgithub commented Jun 8, 2023

huseratgithub commented Jun 10, 2023

zhangyanzhao commented Jun 13, 2023

zhangyanzhao commented Jun 13, 2023

huseratgithub commented Jun 21, 2023 • edited Loading

guxianghong commented Jul 13, 2023

huseratgithub commented Oct 11, 2023

zhangyanzhao commented Oct 11, 2023

huseratgithub commented Oct 12, 2023 • edited Loading

clarklee-guizhao left a comment

Choose a reason for hiding this comment

huseratgithub commented Oct 24, 2023

huseratgithub commented Oct 25, 2023

zhangyanzhao commented Feb 5, 2024

prsunny commented Feb 8, 2024

huseratgithub commented Feb 23, 2024

zhangyanzhao commented May 22, 2024

goomadao commented May 23, 2024

guxianghong commented Jun 1, 2024

zhangyanzhao commented Jun 4, 2024

huseratgithub commented Apr 10, 2023 •

edited

Loading

huseratgithub commented Jun 21, 2023 •

edited

Loading

huseratgithub commented Oct 12, 2023 •

edited

Loading