Add CLIs to support TWAMP Light #3011

guxianghong · 2023-10-12T08:36:00Z

What I did

Add CLIs support TWAMP Light feature according to HLD sonic-net/SONiC#1320

How I did it

Add config command to config twamp-light
Add show command to show twamp-light session

How to verify it

Manual test.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

admin@sonic:~$ sudo config twamp-light session-sender packet-count add snd_1 36.1.1.1 36.1.1.2 1000 10 10 11000
admin@sonic:~$ sudo config twamp-light session-sender continuous add snd_1 22.1.1.1 22.1.1.2 60 100 10 20000
admin@sonic:~$ sudo config twamp-light session-reflector add ref_1 22.1.1.1 22.1.1.2
admin@sonic:~$
admin@sonic:~$ show twamp-light session
Time unit: Monitor Time/Timeout in second; Tx Interval/Stats Interval in millisecond
TWAMP-Light Sender Sessions
Name     Status    Sender IP:PORT    Reflector IP:PORT    Packet Count    Monitor Time      Tx Interval    Stats Interval    Timeout
-------  --------  ----------------  -------------------  --------------  --------------  -------------  ----------------  ---------
snd_1    inactive  36.1.1.1:862      36.1.1.2:863         1000            -                          10             11000         10
snd_2    inactive  22.1.1.1:862      22.1.1.2:863         -               60                        100             20000         10

TWAMP-Light Reflector Sessions
Name    Status    Sender IP:PORT    Reflector IP:PORT
------  --------  ----------------  -------------------
ref_1   active    22.1.1.1:862      22.1.1.2:863
admin@sonic:~$
admin@sonic:~$ sudo config twamp-light session-sender start all
admin@sonic:~$
admin@sonic:~$ show twamp-light statistics twoway-loss
Latest two-way loss statistics:
Name       Index    Loss Count    Loss Ratio
-------  -------  ------------  ------------
snd_1          1             0             0
               2             0             0
               3             0             0
               4             0             0
               5             0             0
               6             0             0
               7             0             0
               8             0             0
               9             0             0
              10             0             0
snd_2          1             0             0
               2             0             0
               3             0             0

Total two-way loss statistics:
Name       Loss Count(AVG)    Loss Count(MIN)    Loss Count(MAX)    Loss Ratio(AVG)    Loss Ratio(MIN)    Loss Ratio(MAX)
-------  -----------------  -----------------  -----------------  -----------------  -----------------  -----------------
snd_1                    0                  0                  0                  0                  0                  0
snd_2                    0                  0                  0                  0                  0                  0
admin@sonic:~$
admin@sonic:~$ show twamp-light statistics twoway-delay
Latest two-way delay statistics(nsec):
Name       Index    Delay(AVG)    Jitter(AVG)
-------  -------  ------------  -------------
snd_1          1          1761              0
               2          1758              0
               3          1761              0
               4          1761              0
               5          1761              0
               6          1758              0
               7          1759              0
               8          1758              0
               9          1759              0
              10          1760              0
snd_2          1          3983              1
               2          3984              1
               3          3987              1

Total two-way delay statistics(nsec):
Name       Delay(AVG)    Delay(MIN)    Delay(MAX)    Jitter(AVG)    Jitter(MIN)    Jitter(MAX)
-------  ------------  ------------  ------------  -------------  -------------  -------------
snd_1            1759          1691          1825              0              0              3
snd_2            3985          3896          4097              0              0              5
admin@sonic:~$

guxianghong · 2023-10-19T12:06:55Z

@qiluo-msft @yxieca @StormLiangMS @prsunny could you please help to review this PR? Thanks.
This feature is tracked for 202311 release and the HLD link is : sonic-net/SONiC#1320
@zhangyanzhao

AlanYoush · 2024-04-02T01:05:57Z

Hi @maipbui, TWAMP Light is for SONiC 202405 Release and sonic-net/SONiC#1320 other submodules is already merged into master.
Please help to review and approve it or assign someone on behalf of you.
Thank you very much.

AlanYoush · 2024-04-07T08:12:04Z

@qiluo-msft Please help to review this MR and approve to merge it.
It is important for TWAMP Light release in SONiC 202405.
Thanks very much.

guxianghong · 2024-04-17T12:38:55Z

This PR is the last one to be merged in the TWAMP light Phase1 release， could you please help to review and merge this PR， @qiluo-msft @yxieca @StormLiangMS @prsunny @prgeor， Thanks very much.

Repo	PR title	State
sonic-swss	TWAMP Light orchagent implementation
sonic-swss-common	Added TWAMP Light table to schema
sonic-sairedis	Support TWAMP Light notification in syncd
sonic-utilities	Added CLIs to support TWAMP Light
SAI	Added TWAMP Light API

zhangyanzhao · 2024-04-26T23:33:36Z

@qiluo-msft @oleksandrivantsiv can you please help to review and merge this PR if you are ok? This is the last open code PR for this feature? Thanks.

zhangyanzhao · 2024-05-06T00:14:23Z

waiting for reviewer's update.

liat-grozovik · 2024-05-15T16:21:04Z

@sonic-utilities-maintainer could you please help to review?

guxianghong · 2024-05-16T12:59:15Z

@sonic-utilities-maintainer could you please help to review?

Thank you for sending the review & merge request.
Please help to review & merge this PR, @qiluo-msft @oleksandrivantsiv @zhangyanzhao . Thanks very much.

zhangyanzhao · 2024-05-22T16:39:18Z

Alibaba is the registered reviewer. @eddieruan-alibaba can you please find someone from Alibaba to review this PR? Thanks.

guxianghong · 2024-06-01T06:53:29Z

@eddieruan-alibaba @qiluo-msft @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @prgeor @clarklee-guizhao Please help to review & merge this PR . Thanks very much.

zhangyanzhao · 2024-06-04T17:17:06Z

@eddieruan-alibaba can you please help to review this PR? Thanks.

eddieruan-alibaba · 2024-06-05T04:49:57Z

I have asked Shuanghong from my team to review it. We are using software twamp

guxianghong · 2024-06-05T09:15:22Z

I have asked Shuanghong from my team to review it. We are using software twamp

Thank you very much for reviewing. The TWAMP light HLD has considered both software and hardware-based TWAMP light solutions, and the implementation in SONiC utility here is unified. We will contribute the software implementation to the community later, and hope your team can help review it at that time, Thanks.

qiluo-msft · 2024-09-23T16:53:27Z

Could you merge the latest master branch? I think 'Semgrep' will be triggered after merging.

guxianghong · 2024-09-24T01:30:22Z

Could you merge the latest master branch? I think 'Semgrep' will be triggered after merging.

Ok, I will rebase this PR.

guxianghong · 2024-09-24T02:31:41Z

It seems that rebase this PR can't trigger Semgrep. Try to close and reopen to trigger Semgrep.

guxianghong · 2024-09-24T07:38:19Z

Could you merge the latest master branch? I think 'Semgrep' will be triggered after merging.

I tried several attempts, such as rebase to latest master, close/reopen this PR, push new commit to this PR, all of them didn't work, Semgrep can't be triggered. Do you have any other suggestions? @qiluo-msft

guxianghong · 2024-09-24T10:01:31Z

/azpw run

mssonicbld · 2024-09-24T10:01:34Z

/AzurePipelines run

azure-pipelines · 2024-09-24T10:01:46Z

Azure Pipelines successfully started running 1 pipeline(s).

guxianghong · 2024-09-24T11:21:02Z

/azp run Semgrep

azure-pipelines · 2024-09-24T11:21:09Z

Commenter does not have sufficient privileges for PR 3011 in repo sonic-net/sonic-utilities

guxianghong · 2024-09-25T01:43:02Z

Could you merge the latest master branch? I think 'Semgrep' will be triggered after merging.

All pipeline checks have passed, Could you please help to approve and merge this PR, Thanks, @qiluo-msft

… PR#1320 Signed-off-by: Xianghong Gu <[email protected]>

guxianghong · 2024-09-26T05:21:17Z

Update to the latest master branch again and resolve conflicts in Command-Reference.md.
Please help to approve and merge this PR, Thakns, @qiluo-msft .

guxianghong · 2024-09-27T01:49:01Z

/azp run Semgrep

azure-pipelines · 2024-09-27T01:49:07Z

Commenter does not have sufficient privileges for PR 3011 in repo sonic-net/sonic-utilities

guxianghong · 2024-09-27T01:49:25Z

/azpw run Semgrep

mssonicbld · 2024-09-27T01:49:28Z

/AzurePipelines run Semgrep

azure-pipelines · 2024-09-27T01:49:34Z

No pipelines are associated with this pull request.

guxianghong · 2024-10-05T05:58:35Z

Please help to merge this PR, @qiluo-msft @zhangyanzhao @liat-grozovik @abdosi @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @zhangyanzhao, Thanks very much.

guxianghong · 2024-10-14T12:19:53Z

All checks have passed, Could you please merge this PR? @qiluo-msft @zhangyanzhao @liat-grozovik @abdosi @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @zhangyanzhao, Thanks very much.

guxianghong · 2024-10-24T12:20:23Z

All checks have passed, Could someone please help to merge this PR? @qiluo-msft @zhangyanzhao @liat-grozovik @abdosi @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @zhangyanzhao, Thanks very much.

guxianghong · 2024-11-04T08:15:00Z

Could someone please help to merge this PR? Or if there are any issues blocking the merge, please let me know.. @qiluo-msft @zhangyanzhao @liat-grozovik @abdosi @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @zhangyanzhao, Thanks very much.

mssonicbld · 2024-12-12T11:21:45Z

/azp run

azure-pipelines · 2024-12-12T11:21:56Z

Azure Pipelines successfully started running 1 pipeline(s).

huseratgithub mentioned this pull request Oct 12, 2023

[TWAMP] Add TWAMP Light feature HLD sonic-net/SONiC#1320

Merged

guxianghong marked this pull request as draft October 12, 2023 11:37

guxianghong force-pushed the devpr_xgu_2023100302_support_twamp branch from 65f699c to 9b4dc9f Compare October 19, 2023 07:33

guxianghong marked this pull request as ready for review October 19, 2023 07:52

guxianghong mentioned this pull request Apr 18, 2024

Two-Way Active Measurement Protocol (TWAMP) Light sonic-net/SONiC#1192

Open

zhangyanzhao requested review from oleksandrivantsiv and qiluo-msft April 23, 2024 23:56

liat-grozovik requested review from a team and removed request for qiluo-msft and oleksandrivantsiv May 15, 2024 16:20

zhangyanzhao requested review from qiluo-msft and eddieruan-alibaba and removed request for a team and qiluo-msft May 22, 2024 16:37

goomadao approved these changes Jun 5, 2024

View reviewed changes

guxianghong force-pushed the devpr_xgu_2023100302_support_twamp branch 2 times, most recently from a560c83 to 5e4ceae Compare August 3, 2024 10:56

guxianghong force-pushed the devpr_xgu_2023100302_support_twamp branch from 5e4ceae to 5282f2a Compare September 24, 2024 01:46

guxianghong closed this Sep 24, 2024

guxianghong reopened this Sep 24, 2024

guxianghong added 3 commits September 26, 2024 10:53

Add CLIs support TWAMP Light feature according to sonic-net/SONiC HLD…

4649320

… PR#1320 Signed-off-by: Xianghong Gu <[email protected]>

Add CLIs support TWAMP Light feature according to sonic-net/SONiC HLD…

b37df39

… PR#1320 Signed-off-by: Xianghong Gu <[email protected]>

Add CLIs support TWAMP Light feature according to sonic-net/SONiC HLD…

294d504

… PR#1320 Signed-off-by: Xianghong Gu <[email protected]>

guxianghong force-pushed the devpr_xgu_2023100302_support_twamp branch from d4621ee to 294d504 Compare September 26, 2024 05:19

Merge branch 'master' into devpr_xgu_2023100302_support_twamp

1a9b6e2

Add CLIs to support TWAMP Light #3011

Are you sure you want to change the base?

Add CLIs to support TWAMP Light #3011

Conversation

guxianghong commented Oct 12, 2023

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

guxianghong commented Oct 19, 2023

AlanYoush commented Apr 2, 2024

AlanYoush commented Apr 7, 2024

guxianghong commented Apr 17, 2024

zhangyanzhao commented Apr 26, 2024

zhangyanzhao commented May 6, 2024

liat-grozovik commented May 15, 2024

guxianghong commented May 16, 2024

zhangyanzhao commented May 22, 2024

guxianghong commented Jun 1, 2024

zhangyanzhao commented Jun 4, 2024

eddieruan-alibaba commented Jun 5, 2024

guxianghong commented Jun 5, 2024

qiluo-msft commented Sep 23, 2024

guxianghong commented Sep 24, 2024

guxianghong commented Sep 24, 2024

guxianghong commented Sep 24, 2024

guxianghong commented Sep 24, 2024

mssonicbld commented Sep 24, 2024

azure-pipelines bot commented Sep 24, 2024

guxianghong commented Sep 24, 2024

azure-pipelines bot commented Sep 24, 2024

guxianghong commented Sep 25, 2024 • edited Loading

guxianghong commented Sep 26, 2024

guxianghong commented Sep 27, 2024

azure-pipelines bot commented Sep 27, 2024

guxianghong commented Sep 27, 2024

mssonicbld commented Sep 27, 2024

azure-pipelines bot commented Sep 27, 2024

guxianghong commented Oct 5, 2024

guxianghong commented Oct 14, 2024

guxianghong commented Oct 24, 2024

guxianghong commented Nov 4, 2024

mssonicbld commented Dec 12, 2024

azure-pipelines bot commented Dec 12, 2024

guxianghong commented Sep 25, 2024 •

edited

Loading