Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLD for diagnostic monitoring of CMIS based transceivers #1828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mihirpat1
Copy link
Contributor

@mihirpat1 mihirpat1 commented Oct 11, 2024

This HLD while provide an overview of how SONiC reads and stores the various diagnostic parameters read from a CMIS based transceiver.

Proposed changes for existing tables in SONiC

  1. Removed CCMIS specific VDM data from DOM related tables and moved to VDM related tables
  2. Not all VDM thresholds are currently shown.
  3. With the proposed changes, I am planning to change the name of existing fields to be in line with the CMIS spec.
  4. Moved txfault, txlos, txcdrlol, rxlos and rxcdrlol from TRANSCEIVER_STATUS to TRANSCEIVER_DOM_FLAG table.

@mihirpat1 mihirpat1 requested a review from prgeor October 11, 2024 06:26
@mihirpat1
Copy link
Contributor Author

@qinchuanares - It will be great if you can help in reviewing this PR.

@mihirpat1
Copy link
Contributor Author

@Junchao-Mellanox @keboliu - It will be great if you can help in reviewing this PR.


### 4.2 Dynamic Diagnostic Information

The `DomInfoUpdateTask` thread is responsible for updating the dynamic diagnostic information for all the transceivers in the system. The `DomInfoUpdateTask` thread is triggered by a timer (`DOM_INFO_UPDATE_PERIOD_SECS`), which is set to 60 seconds by default. The `DomInfoUpdateTask` thread reads the diagnostic information from the transceiver and updates the relevant tables in `redis-db`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious if there is any plan for making this alarm logging interrupt based?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prgeor Can you please help in clarifying this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants