Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:6022] Added support for running T2 applicable tests using vsonic(KVM) for n… #11853

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Added support for running T2 applicable tests using vsonic(KVM) for neighbors

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • [ x] Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

To add support for vsonic/KVM commands on neighbors, as the commands are different from Eo

How did you do it?

  1. Fix for test_lldp testcase:
    KVM neighbors do not advertise port ifname. They instead advertise 'descr'. We will use ifname for EosHost and descr for KVM

  2. Fix for test_snmp_loopback testcase:
    snmpget command requires running in snmp docker

Eos Example:
ARISTA01T3#bash snmpget -v2c -c public 10.1.0.1 1.3.6.1.2.1.1.1.0
SNMPv2-MIB::sysDescr.0 = STRING: SONiC Software Version: SONiC.HEAD.291231-msft-2205-c679f2d - HwSku: Nokia-
IXR7250E-36x100G - Distribution: Debian 11.4 - Kernel: 5.10.0-12-2-amd64

vSonic Exmple:
admin@ARISTA01T1:~$ docker exec -it snmp snmpget -v2c -c public 10.1.0.1 1.3.6.1.2.1.1.1.0
iso.3.6.1.2.1.1.1.0 = STRING: "SONiC Software Version: SONiC.HEAD.291231-msft-2205-c679f2d - HwSku: Nokia-IXR7250E-
6x400G - Distribution: Debian 11.4 - Kernel: 5.10.0-12-2-amd64"

  1. Fix for voq tests
    BGP:
  • Use vtysh for BGP configuration on vsonic
    Interface up/down:
  • Use shut/no shut commands
  1. voq_helper
    Interface name and numbering:
  • Neighbors interface name is difference on vsonic vs Eos.
  • On Eos, inerfaces are named 'eth' (Ex. eth1) and portchannels are named po (Ex. po1).
  • On vsonic, interfaces are named Ethernet (Ex. Ethernet1) and portchannels are named PortChannel (PortChannel1).
  1. Fix for test_lag interface
    There is no support for setting lacp rate in vsonic. So, skipping these tests.

How did you verify/test it?

Tested the code on a dut that uses Eos VM as it's neighbors in one setup and against vsonic neighbors in another setup.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

sonic-net#6022)

* Added support for running T2 applicable tests using vsonic(KVM) for neighbors

1. Fix for test_lldp testcase:
  KVM neighbors do not advertise port ifname. They instead advertise 'descr'.  We will use ifname for EosHost and descr for KVM
2. Fix for test_snmp_loopback testcase:
  snmpget command requires running in snmp docker
3. voq tests
  BGP:
    - Use vtysh for BGP configuration on vsonic
  Interface up/down:
    - Use shut/no shut commands

  Interface name and numbering:
    - Neighbors interface name is difference on vsonic vs Eos.
      - On Eos, inerfaces are named 'eth' (Ex. eth1) and portchannels are named po (Ex. po1).
      - On vsonic, interfaces are named Ethernet (Ex. Ethernet1) and portchannels are named PortChannel (PortChannel1).
@mssonicbld
Copy link
Collaborator Author

Original PR: #6022

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit d1e6be6 into sonic-net:202311 Mar 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants