Added support for running T2 applicable tests using vsonic(KVM) for n… #6022

mannytaheri · 2022-07-21T22:22:39Z

Description of PR

Added support for running T2 applicable tests using vsonic(KVM) for neighbors

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
[ x] Test case(new/improvement)

Back port request

201911
202012
202205

Approach

What is the motivation for this PR?

To add support for vsonic/KVM commands on neighbors, as the commands are different from Eo

How did you do it?

Fix for test_lldp testcase:
KVM neighbors do not advertise port ifname. They instead advertise 'descr'. We will use ifname for EosHost and descr for KVM
Fix for test_snmp_loopback testcase:
snmpget command requires running in snmp docker

Eos Example:
ARISTA01T3#bash snmpget -v2c -c public 10.1.0.1 1.3.6.1.2.1.1.1.0
SNMPv2-MIB::sysDescr.0 = STRING: SONiC Software Version: SONiC.HEAD.291231-msft-2205-c679f2d - HwSku: Nokia-
IXR7250E-36x100G - Distribution: Debian 11.4 - Kernel: 5.10.0-12-2-amd64

vSonic Exmple:
admin@ARISTA01T1:~$ docker exec -it snmp snmpget -v2c -c public 10.1.0.1 1.3.6.1.2.1.1.1.0
iso.3.6.1.2.1.1.1.0 = STRING: "SONiC Software Version: SONiC.HEAD.291231-msft-2205-c679f2d - HwSku: Nokia-IXR7250E-
6x400G - Distribution: Debian 11.4 - Kernel: 5.10.0-12-2-amd64"
Fix for voq tests
BGP:
- Use vtysh for BGP configuration on vsonic
Interface up/down:
- Use shut/no shut commands
voq_helper
Interface name and numbering:
- Neighbors interface name is difference on vsonic vs Eos.
  - On Eos, inerfaces are named 'eth' (Ex. eth1) and portchannels are named po (Ex. po1).
  - On vsonic, interfaces are named Ethernet (Ex. Ethernet1) and portchannels are named PortChannel (PortChannel1).
Fix for test_lag interface
There is no support for setting lacp rate in vsonic. So, skipping these tests.

How did you verify/test it?

Tested the code on a dut that uses Eos VM as it's neighbors in one setup and against vsonic neighbors in another setup.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

lgtm-com · 2022-07-21T22:45:58Z

This pull request introduces 1 alert when merging bad9a3177e129a72f4725b1aa5888945ca427fc5 into e33b228 - view on LGTM.com

new alerts:

1 for Unused import

tjchadaga · 2022-10-27T19:00:53Z

/easycla

tests/voq/test_voq_nbr.py

arlakshm

as comments

azure-pipelines · 2022-11-16T21:07:20Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/pc/test_lag_2.py Fixing tests/lldp/test_lldp.py fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing tests/snmp/test_snmp_loopback.py check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

abdosi · 2023-03-01T18:50:36Z

cc @judyjoseph

abdosi · 2023-03-01T18:51:39Z

@sanmalho-git Can we close this soon.

abdosi · 2023-03-01T18:52:01Z

/azp run

azure-pipelines · 2023-03-01T18:52:10Z

Azure Pipelines successfully started running 1 pipeline(s).

wangxin · 2023-03-01T18:52:46Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/pc/test_lag_2.py Fixing tests/lldp/test_lldp.py fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing tests/snmp/test_snmp_loopback.py Fixing tests/voq/test_voq_nbr.py check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mrkcmo · 2023-03-02T15:13:14Z

Which topology was this ran in for this setup? Was it the t2-topo?

mannytaheri · 2023-03-02T15:33:28Z

Which topology was this ran in for this setup? Was it the t2-topo?

T2 Toplogy

mrkcmo · 2023-03-02T15:36:47Z

Which topology was this ran in for this setup? Was it the t2-topo?

T2 Toplogy

Thanks. Was this a physical T2 setup with vSONIC KVM neighbors?

mannytaheri · 2023-03-02T16:25:01Z

Which topology was this ran in for this setup? Was it the t2-topo?

T2 Toplogy

Thanks. Was this a physical T2 setup with vSONIC KVM neighbors?

The topology that we are using is T2_min with a physical chassis with 2 Linecards and 1 supervisor card and all eBGP peers being simulated using vsonic

mssonicbld · 2023-04-06T21:49:33Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/pc/test_lag_2.py fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing tests/fib/test_fib.py check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2023-04-21T17:28:06Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 ansible/roles/test/files/tools/loganalyzer/loganalyzer.py:38:1: E265 block comment should start with '# ' ansible/roles/test/files/tools/loganalyzer/loganalyzer.py:40:1: E265 block comment should start with '# ' ansible/roles/test/files/tools/loganalyzer/loganalyzer.py:46:1: E265 block comment should start with '# ' ansible/roles/test/files/tools/loganalyzer/loganalyzer.py:56:1: E302 expected 2 blank lines, found 1 ansible/roles/test/files/tools/loganalyzer/loganalyzer.py:92:57: E251 unexpected spaces around keyword / parameter equals ansible/roles/test/files/tools/loganalyzer/loganalyzer.py:92:59: E251 unexpected spaces around keyword / parameter equals ansible/roles/test/files/tools/loganalyzer/loganalyzer.py:95:5: E265 block comment should start with '# ' ansible/roles/test/files/tools/loganalyzer/loganalyzer.py:97:53: E251 unexpected spaces around keyword / parameter equals ansible/roles/test/files/tools/loganalyzer/loganalyzer.py:97:55: E251 unexpected spaces around keyword / parameter equals ansible/roles/test/files/tools/loganalyzer/loganalyzer.py:101:5: E265 block comment should start with '# ' ansible/roles/test/files/tools/loganalyzer/loganalyzer.py:108:5: E265 block comment should start with '# ' ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

arlakshm · 2023-04-27T17:50:20Z

/Azp run Azure.sonic-mgmt

mssonicbld · 2023-06-05T18:05:55Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/fib/test_fib.py:77:20: F811 redefinition of unused 'toggle_all_simulator_ports_to_random_side' from line 17 tests/fib/test_fib.py:78:20: F811 redefinition of unused 'fib_info_files_per_function' from line 20 tests/fib/test_fib.py:79:36: F811 redefinition of unused 'mux_server_url' from line 15 tests/fib/test_fib.py:81:32: F811 redefinition of unused 'single_fib_for_duts' from line 21 tests/fib/test_fib.py:289:51: F811 redefinition of unused 'fib_info_files_per_function' from line 20 tests/fib/test_fib.py:290:15: F811 redefinition of unused 'toggle_all_simulator_ports_to_rand_selected_tor_m' from line 16 tests/fib/test_fib.py:291:31: F811 redefinition of unused 'mux_server_url' from line 15 tests/fib/test_fib.py:292:27: F811 redefinition of unused 'single_fib_for_duts' from line 21 tests/lldp/test_lldp.py:3:1: F401 'tests.common.devices.eos.EosHost' imported but unused tests/lldp/test_lldp.py:21:121: E501 line too long (143 > 120 characters) tests/lldp/test_lldp.py:88:121: E501 line too long (129 > 120 characters) ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

ansible/roles/test/files/tools/loganalyzer/loganalyzer.py

mannytaheri · 2024-02-22T20:36:02Z

@judyjoseph I removed that section of the code as it is not related to this PR. All tests have passed.

SuvarnaMeenakshi

lgtm

mssonicbld · 2024-03-04T06:32:54Z

@mannytaheri PR conflicts with 202205 branch

sonic-net#6022) * Added support for running T2 applicable tests using vsonic(KVM) for neighbors 1. Fix for test_lldp testcase: KVM neighbors do not advertise port ifname. They instead advertise 'descr'. We will use ifname for EosHost and descr for KVM 2. Fix for test_snmp_loopback testcase: snmpget command requires running in snmp docker 3. voq tests BGP: - Use vtysh for BGP configuration on vsonic Interface up/down: - Use shut/no shut commands Interface name and numbering: - Neighbors interface name is difference on vsonic vs Eos. - On Eos, inerfaces are named 'eth' (Ex. eth1) and portchannels are named po (Ex. po1). - On vsonic, interfaces are named Ethernet (Ex. Ethernet1) and portchannels are named PortChannel (PortChannel1).

mssonicbld · 2024-03-04T06:32:58Z

Cherry-pick PR to 202305: #11852

mssonicbld · 2024-03-04T06:32:58Z

Cherry-pick PR to 202311: #11853

#6022) * Added support for running T2 applicable tests using vsonic(KVM) for neighbors 1. Fix for test_lldp testcase: KVM neighbors do not advertise port ifname. They instead advertise 'descr'. We will use ifname for EosHost and descr for KVM 2. Fix for test_snmp_loopback testcase: snmpget command requires running in snmp docker 3. voq tests BGP: - Use vtysh for BGP configuration on vsonic Interface up/down: - Use shut/no shut commands Interface name and numbering: - Neighbors interface name is difference on vsonic vs Eos. - On Eos, inerfaces are named 'eth' (Ex. eth1) and portchannels are named po (Ex. po1). - On vsonic, interfaces are named Ethernet (Ex. Ethernet1) and portchannels are named PortChannel (PortChannel1).

sonic-net#6022) * Added support for running T2 applicable tests using vsonic(KVM) for neighbors 1. Fix for test_lldp testcase: KVM neighbors do not advertise port ifname. They instead advertise 'descr'. We will use ifname for EosHost and descr for KVM 2. Fix for test_snmp_loopback testcase: snmpget command requires running in snmp docker 3. voq tests BGP: - Use vtysh for BGP configuration on vsonic Interface up/down: - Use shut/no shut commands Interface name and numbering: - Neighbors interface name is difference on vsonic vs Eos. - On Eos, inerfaces are named 'eth' (Ex. eth1) and portchannels are named po (Ex. po1). - On vsonic, interfaces are named Ethernet (Ex. Ethernet1) and portchannels are named PortChannel (PortChannel1). (cherry picked from commit 0a3acb7)

#6022) (#11905) * Added support for running T2 applicable tests using vsonic(KVM) for neighbors 1. Fix for test_lldp testcase: KVM neighbors do not advertise port ifname. They instead advertise 'descr'. We will use ifname for EosHost and descr for KVM 2. Fix for test_snmp_loopback testcase: snmpget command requires running in snmp docker 3. voq tests BGP: - Use vtysh for BGP configuration on vsonic Interface up/down: - Use shut/no shut commands Interface name and numbering: - Neighbors interface name is difference on vsonic vs Eos. - On Eos, inerfaces are named 'eth' (Ex. eth1) and portchannels are named po (Ex. po1). - On vsonic, interfaces are named Ethernet (Ex. Ethernet1) and portchannels are named PortChannel (PortChannel1). (cherry picked from commit 0a3acb7)

mannytaheri requested a review from a team as a code owner July 21, 2022 22:22

rlhui added the chassis label Sep 21, 2022

rlhui assigned arlakshm Sep 21, 2022

arlakshm reviewed Nov 2, 2022

View reviewed changes

tests/voq/test_voq_nbr.py Outdated Show resolved Hide resolved

arlakshm reviewed Nov 2, 2022

View reviewed changes

tests/voq/test_voq_nbr.py Outdated Show resolved Hide resolved

arlakshm reviewed Nov 2, 2022

View reviewed changes

tests/voq/test_voq_nbr.py Show resolved Hide resolved

arlakshm reviewed Nov 2, 2022

View reviewed changes

rlhui assigned SuvarnaMeenakshi Mar 29, 2023

mannytaheri force-pushed the kvm_support branch from 987c664 to fd575e5 Compare April 6, 2023 21:48

mannytaheri force-pushed the kvm_support branch from fd575e5 to 3a4fd6d Compare April 21, 2023 17:27

mannytaheri force-pushed the kvm_support branch from 3a4fd6d to cd1b3c9 Compare June 5, 2023 18:04

mannytaheri requested review from ZhaohuiS and jcaiMR as code owners June 5, 2023 18:04

mannytaheri force-pushed the kvm_support branch from cd1b3c9 to a3f9293 Compare June 5, 2023 20:19

judyjoseph reviewed Feb 22, 2024

View reviewed changes

ansible/roles/test/files/tools/loganalyzer/loganalyzer.py Outdated Show resolved Hide resolved

Removed changes in loganalyzer.py

7a45862

SuvarnaMeenakshi approved these changes Feb 27, 2024

View reviewed changes

judyjoseph approved these changes Feb 27, 2024

View reviewed changes

judyjoseph merged commit 0a3acb7 into sonic-net:master Feb 27, 2024
13 checks passed

judyjoseph added Request for 202205 branch Request for 202305 branch Request for 202311 branch labels Feb 27, 2024

wangxin added Approved for 202205 branch Approved for 202305 branch Approved for 202311 branch labels Mar 4, 2024

mssonicbld added the Cherry Pick Conflict_202205 label Mar 4, 2024

mssonicbld added the Created PR to 202305 branch label Mar 4, 2024

mssonicbld added the Created PR to 202311 branch label Mar 4, 2024

This was referenced Mar 4, 2024

[action] [PR:6022] Added support for running T2 applicable tests using vsonic(KVM) for n… #11852

Merged

[action] [PR:6022] Added support for running T2 applicable tests using vsonic(KVM) for n… #11853

Merged

mssonicbld added Included in 202305 branch and removed Created PR to 202305 branch labels Mar 4, 2024

mssonicbld added Included in 202311 branch and removed Created PR to 202311 branch labels Mar 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for running T2 applicable tests using vsonic(KVM) for n… #6022

Added support for running T2 applicable tests using vsonic(KVM) for n… #6022

mannytaheri commented Jul 21, 2022 •

edited

Loading

lgtm-com bot commented Jul 21, 2022

tjchadaga commented Oct 27, 2022

arlakshm left a comment

azure-pipelines bot commented Nov 16, 2022

abdosi commented Mar 1, 2023

abdosi commented Mar 1, 2023

abdosi commented Mar 1, 2023

azure-pipelines bot commented Mar 1, 2023

wangxin commented Mar 1, 2023

mrkcmo commented Mar 2, 2023

mannytaheri commented Mar 2, 2023

mrkcmo commented Mar 2, 2023

mannytaheri commented Mar 2, 2023

mssonicbld commented Apr 6, 2023

mssonicbld commented Apr 21, 2023

arlakshm commented Apr 27, 2023

mssonicbld commented Jun 5, 2023

mannytaheri commented Feb 22, 2024 •

edited

Loading

SuvarnaMeenakshi left a comment

mssonicbld commented Mar 4, 2024

mssonicbld commented Mar 4, 2024

mssonicbld commented Mar 4, 2024

Added support for running T2 applicable tests using vsonic(KVM) for n… #6022

Added support for running T2 applicable tests using vsonic(KVM) for n… #6022

Conversation

mannytaheri commented Jul 21, 2022 • edited Loading

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

lgtm-com bot commented Jul 21, 2022

tjchadaga commented Oct 27, 2022

arlakshm left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Nov 16, 2022

abdosi commented Mar 1, 2023

abdosi commented Mar 1, 2023

abdosi commented Mar 1, 2023

azure-pipelines bot commented Mar 1, 2023

wangxin commented Mar 1, 2023

mrkcmo commented Mar 2, 2023

mannytaheri commented Mar 2, 2023

mrkcmo commented Mar 2, 2023

mannytaheri commented Mar 2, 2023

mssonicbld commented Apr 6, 2023

mssonicbld commented Apr 21, 2023

arlakshm commented Apr 27, 2023

mssonicbld commented Jun 5, 2023

mannytaheri commented Feb 22, 2024 • edited Loading

SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

mssonicbld commented Mar 4, 2024

mssonicbld commented Mar 4, 2024

mssonicbld commented Mar 4, 2024

mannytaheri commented Jul 21, 2022 •

edited

Loading

mannytaheri commented Feb 22, 2024 •

edited

Loading