Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect. #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Sep 15, 2023
| @@ -50,7 +50,8 @@ stages: | |||
| - script: | | |||
| set -ex | |||
| sudo apt-get -y purge libhiredis-dev libnl-3-dev libnl-route-3-dev | |||
| sudo dpkg -i ../target/debs/buster/{libyang_1.0.73_amd64.deb,libswsscommon_1.0.0_amd64.deb,python3-swsscommon_1.0.0_amd64.deb,libnl-3-200_*.deb,libnl-genl-3-200_*.deb,libnl-nf-3-200_*.deb,libnl-route-3-200_*.deb,libhiredis0.14_*.deb} | |||
| sudo apt-get -y install libhiredis0.14 | |||
There was a problem hiding this comment.
No, the original pipeline only install libhiredis0.14, I want keeps no change.
qiluo-msft
reviewed
Sep 15, 2023
| @@ -50,7 +50,8 @@ stages: | |||
| - script: | | |||
| set -ex | |||
| sudo apt-get -y purge libhiredis-dev libnl-3-dev libnl-route-3-dev | |||
There was a problem hiding this comment.
No, I want keep this line no change, only install missing libhiredis0.14.
Also the next line, does not install self-build libhiredis-dev:
sudo dpkg -i ../target/debs/buster/{libyang_1.0.73_amd64.deb,libswsscommon_1.0.0_amd64.deb,python3-swsscommon_1.0.0_amd64.deb,libnl-3-200_.deb,libnl-genl-3-200_.deb,libnl-nf-3-200_.deb,libnl-route-3-200_.deb}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect.
Pipeline build break because sonic-buildimage repo not build libhredis by this PR: sonic-net/sonic-buildimage#15633
- What I did
Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect.
- How I did it
Install libhiredis0.14 from debian apt source.
- How to verify it
Pass all UT
- Description for the changelog
Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect.