Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect. #293

Merged
merged 3 commits into from
Sep 16, 2023
Merged

Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect. #293

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23e87e2
Fix pipeline build break caused by libhredis remove from sonic-buildi…
liuh-80 Sep 15, 2023
0ba1ad0
Update azure-pipelines.yml
liuh-80 Sep 15, 2023
83a44e7
Update azure-pipelines.yml
liuh-80 Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ stages:
- script: |
set -ex
sudo apt-get -y purge libhiredis-dev libnl-3-dev libnl-route-3-dev
Copy link
Contributor

@qiluo-msft qiluo-msft Sep 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libhiredis-dev

The intention of purging is to remove all the self-build packages from the env. Since it is not self-build anymore, will this line fail? do you want to stop purge this package? #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I want keep this line no change, only install missing libhiredis0.14.
Also the next line, does not install self-build libhiredis-dev:

sudo dpkg -i ../target/debs/buster/{libyang_1.0.73_amd64.deb,libswsscommon_1.0.0_amd64.deb,python3-swsscommon_1.0.0_amd64.deb,libnl-3-200_.deb,libnl-genl-3-200_.deb,libnl-nf-3-200_.deb,libnl-route-3-200_.deb}

sudo dpkg -i ../target/debs/buster/{libyang_1.0.73_amd64.deb,libswsscommon_1.0.0_amd64.deb,python3-swsscommon_1.0.0_amd64.deb,libnl-3-200_*.deb,libnl-genl-3-200_*.deb,libnl-nf-3-200_*.deb,libnl-route-3-200_*.deb,libhiredis0.14_*.deb}
sudo apt-get -y install libhiredis0.14
Copy link
Contributor

@qiluo-msft qiluo-msft Sep 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libhiredis0

Do you want to install libhiredis-dev?
#Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the original pipeline only install libhiredis0.14, I want keeps no change.

sudo dpkg -i ../target/debs/buster/{libyang_1.0.73_amd64.deb,libswsscommon_1.0.0_amd64.deb,python3-swsscommon_1.0.0_amd64.deb,libnl-3-200_*.deb,libnl-genl-3-200_*.deb,libnl-nf-3-200_*.deb,libnl-route-3-200_*.deb}
sudo python3 -m pip install ../target/python-wheels/buster/swsssdk*-py3-*.whl
sudo python3 -m pip install ../target/python-wheels/buster/sonic_py_common-1.0-py3-none-any.whl
python3 setup.py bdist_wheel
Expand Down