Improvements #267
Merged
Improvements #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In a long list the cards would sligthly be covered and hard to read, now the offset is center
- Also set top corner radiuses to 0, to form a comic bubble-shape
- The pill-texts looked too blurry
- All buttons have same distance between each other and borders of card
- We calculate the screen width, and scale depending on it
- If error -> red border for Input
- Add margin -1 so the element wont resize when focused
- More space between elements
- Remove unused yellow
- Title has a coloured bg, bottom is white
- Remove the icon with no padding
- We resize the banner depending on screen-size - We don't want the keyboard affect the banner-size (android)
rottabonus
force-pushed
the
felix/improvements
branch
from
2a7ac8c to
f808e52
Compare
- Add a post install workaround for deprecated c++ func
rottabonus
force-pushed
the
felix/improvements
branch
2 times, most recently
from
20ae628 to
6cffdc9
Compare
rottabonus
force-pushed
the
felix/improvements
branch
from
35ee7be to
63f46c6
Compare
- always trigger onFocus-styles away, and then the optional callback
rottabonus
commented
Feb 13, 2024
rottabonus
commented
Feb 13, 2024
rottabonus
commented
Feb 13, 2024
idolgov
previously approved these changes
Feb 13, 2024
pheis
reviewed
Feb 14, 2024
pheis
reviewed
Feb 14, 2024
pheis
reviewed
Feb 14, 2024
pheis
previously approved these changes
Feb 14, 2024
- Change ternary to normal logic operator - Rename keyboard listeners for readability - Remove unused test (no admin login) - Remove dead code from admin login
rottabonus
force-pushed
the
felix/improvements
branch
from
b637e80 to
ae0de70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
Introduces a big list of improvements from Trello-ticket
Why was the change made?
Fixing bugs and implementing improvements found out in our demo-review-session. We try to "polish" the app in a state that we can start focusing on the web application and leave the mobile app to be for a bit
Caveats?
N/A
Related Trello issue
Link to the Trello ticket
Link to the translation changes ticket
Link to the test review round 1 ticket
Link to the test review round 2 ticket
Checklist