Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #267

Merged
merged 50 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
35e03ce
Fix interval for FlatList
rottabonus Dec 2, 2023
60f3f4a
Fix sortMe default return
rottabonus Dec 2, 2023
30575bd
Set Chat-bubble maxWidht to 80%
rottabonus Dec 2, 2023
daf2869
Fix lastMessage in BuddyList
rottabonus Dec 2, 2023
bd7b5a8
Remove textShadow from MentorCard-pills
rottabonus Dec 10, 2023
e4dba1a
Fix Sign-screen layout
rottabonus Dec 10, 2023
ef0893f
Auto-scale logo in OnboardingBackground
rottabonus Dec 10, 2023
535dedc
Add InfoBox and improve error-state for Input
rottabonus Dec 10, 2023
37a6822
Fix margin when focusedBorder
rottabonus Dec 10, 2023
c8f9b77
Use InfoBox in Onboarding
rottabonus Dec 10, 2023
5da0ca7
Fix Settings Screen PasswordForm
rottabonus Dec 10, 2023
4585882
Improve LoginCard layout
rottabonus Dec 17, 2023
65ffcc0
Show status-box for 'you' and 'vacationing' in MentorCards
rottabonus Dec 17, 2023
b133889
Improve LoginCard with different sized screens
rottabonus Dec 22, 2023
fde6830
Improve UnseenDot
rottabonus Dec 22, 2023
1153cdf
Make Modals like in new Web
rottabonus Dec 22, 2023
fd22a23
Use Web's send-icon
rottabonus Dec 23, 2023
72269d3
Update iOS-store icon
rottabonus Dec 23, 2023
4df6f2e
Change MentorSearch bg to white
rottabonus Dec 23, 2023
3189462
Update translations, add sekasin-link to welcome
rottabonus Dec 30, 2023
3e118c4
Add sekasinUrl to config and readme
rottabonus Dec 30, 2023
a0a3dc0
Improve error-color for input-icon
rottabonus Dec 30, 2023
280217f
Improve Welcome-screen
rottabonus Dec 30, 2023
e081b35
Add translations for admin login
rottabonus Jan 13, 2024
0886485
Implement admin-login
rottabonus Jan 13, 2024
0c3082f
Update security vulnerabilities
rottabonus Jan 13, 2024
34b461b
Add sekasinUrl to appcenter prebuild-config
rottabonus Jan 13, 2024
9e541c0
Add e2e for admin login
rottabonus Jan 14, 2024
13955e1
Fix e2e tests
rottabonus Jan 14, 2024
00c7de7
Update jest and jest-circus
rottabonus Jan 14, 2024
f93dd89
Fix mentor sorting
rottabonus Jan 20, 2024
fb3a514
Update translations
rottabonus Jan 20, 2024
f311b65
Improve Onboarding Sign-screen
rottabonus Jan 20, 2024
b43e98d
Unify PrivPol-padding to match Onboarding-Screens
rottabonus Jan 20, 2024
6d25168
Add mentor sorting test
rottabonus Jan 20, 2024
5f8c50e
Revert to Link-component
rottabonus Jan 21, 2024
17c3ce1
Improve consistency of Sign-banner
rottabonus Jan 21, 2024
d49c91a
Shorten admin-login title
rottabonus Jan 21, 2024
0c78fac
Update detox
rottabonus Jan 21, 2024
ed80fce
Add english translation
rottabonus Jan 21, 2024
f3bcd43
Fix useLayout for OnboardingBg
rottabonus Jan 21, 2024
e674948
Fix e2e tests for android
rottabonus Jan 21, 2024
f808e52
Fix translations based on review
rottabonus Jan 23, 2024
2042f14
Add update-profile for actors, fix typo
rottabonus Feb 3, 2024
244a06d
Fix translation age
rottabonus Feb 4, 2024
458df75
Remove admin-login
rottabonus Feb 7, 2024
aa847e7
Update Podfile
rottabonus Feb 7, 2024
63f46c6
Add post-clone script to install correct cocoapods-version
rottabonus Feb 11, 2024
d33c170
Improve NamedInputField onBlur
rottabonus Feb 11, 2024
ae0de70
Improve shouldSetHeight condition, remove dead code
rottabonus Feb 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ You can edit the config file as suited:
| `termsUrl` | Terms and conditions URL |
| `userGuideUrl` | User's manual URL |
| `apuuUrl` | Apuu-chat URL |
| `sekasinUrl` | Sekasin-chat URL |
| `messageFetchDelay`| Delay between polling |


Expand Down
14 changes: 14 additions & 0 deletions appcenter-post-clone.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#!/usr/bin/env bash
CUR_COCOAPODS_VER=`sed -n -e 's/^COCOAPODS: \([0-9.]*\)/\1/p' ios/Podfile.lock`
ENV_COCOAPODS_VER=`pod --version`

# check if not the same version, reinstall cocoapods version to current project's
if [ $CUR_COCOAPODS_VER != $ENV_COCOAPODS_VER ];
then
echo "Uninstalling all CocoaPods versions"
sudo gem uninstall cocoapods --all --executables
echo "Installing CocoaPods version $CUR_COCOAPODS_VER"
sudo gem install cocoapods -v $CUR_COCOAPODS_VER
else
echo "CocoaPods version is suitable for the project"
fi;
1 change: 1 addition & 0 deletions appcenter-pre-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ tee config.json > /dev/null <<EOF
"termsUrl": "$YLITSE_TERMSURL",
"userGuideUrl": "$YLITSE_USERGUIDEURL",
"apuuUrl": "$YLITSE_APUUURL",
"sekasinUrl": "$YLITSE_SEKASINURL",
"messageFetchDelay": $YLITSE_MESSAGEFETCHDELAY
}
EOF
1 change: 1 addition & 0 deletions config.template.android.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
"termsUrl": "http://10.0.2.2:3000",
"userGuideUrl": "http://10.0.2.2:3000",
"apuuUrl": "http://10.0.2.2:3000",
"sekasinUrl": "http://10.0.2.2:3000",
"messageFetchDelay": 2000
}
1 change: 1 addition & 0 deletions config.template.ios.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
"termsUrl": "http://localhost:3000",
"userGuideUrl": "http://localhost:3000",
"apuuUrl": "http://localhost:3000",
"sekasinUrl": "http://localhost:3000",
"messageFetchDelay": 2000
}
8 changes: 4 additions & 4 deletions e2e/browseMentorsTest.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe('Browse mentors', () => {
try {
await expect(
element(by.text(accountFixtures.mentors[i].displayName)),
).toBeVisible();
).toBeVisible(50);
mentorsFound[accountFixtures.mentors[i].displayName] = true;
} catch (error) {
continue;
Expand All @@ -70,7 +70,7 @@ describe('Browse mentors', () => {
try {
await expect(
element(by.text(accountFixtures.mentors[i].displayName)),
).toBeVisible();
).toBeVisible(50);
mentorsFound[accountFixtures.mentors[i].displayName] = true;
} catch (error) {
continue;
Expand All @@ -83,7 +83,7 @@ describe('Browse mentors', () => {
try {
await expect(
element(by.text(accountFixtures.mentors[i].displayName)),
).toBeVisible();
).toBeVisible(50);
mentorsFound[accountFixtures.mentors[i].displayName] = true;
} catch (error) {
continue;
Expand Down Expand Up @@ -186,7 +186,7 @@ describe('Browse mentors', () => {

await signIn(mentor);

await expect(element(by.text(mentor.displayName))).toBeVisible();
await expect(element(by.text(mentor.displayName))).toBeVisible(50);
await element(by.text('Show mentor')).atIndex(0).tap();

await element(by.text('Chat')).tap();
Expand Down
1 change: 1 addition & 0 deletions e2e/chatTest.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
describe('Chat', () => {
beforeAll(async () => {
await device.launchApp();
jest.setTimeout(200000);
});
beforeEach(async () => {
await APIDeleteAccounts();
Expand Down
6 changes: 3 additions & 3 deletions e2e/filterSkillTest.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe('Skill filter', () => {
try {
await expect(
element(by.text(accountFixtures.mentors[i].displayName)),
).toBeVisible();
).toBeVisible(50);
mentorsFound[accountFixtures.mentors[i].displayName] = true;
} catch (error) {
continue;
Expand All @@ -64,7 +64,7 @@ describe('Skill filter', () => {
try {
await expect(
element(by.text(accountFixtures.mentors[i].displayName)),
).toBeVisible();
).toBeVisible(50);
mentorsFound[accountFixtures.mentors[i].displayName] = true;
} catch (error) {
continue;
Expand All @@ -77,7 +77,7 @@ describe('Skill filter', () => {
try {
await expect(
element(by.text(accountFixtures.mentors[i].displayName)),
).toBeVisible();
).toBeVisible(50);
mentorsFound[accountFixtures.mentors[i].displayName] = true;
} catch (error) {
continue;
Expand Down
8 changes: 8 additions & 0 deletions e2e/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ const API_USER = process.env.YLITSE_API_USER || 'admin';
const API_PASS = process.env.YLITSE_API_PASS || '';
const MFA_SECRET = process.env.YLITSE_MFA_SECRET || '';

export const getAdminCredentials = () => {
return {
user: API_USER,
pass: API_PASS,
token: generateToken(MFA_SECRET)?.token,
};
};

/**
* Scrolls view down if needed and taps the given element
*/
Expand Down
2 changes: 1 addition & 1 deletion e2e/hideInactiveMentorsTest.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const findMentor = async (mentorIndexes: any, mentorsFound: any) => {
try {
await expect(
element(by.text(accountFixtures.mentors[Number(i)].displayName)),
).toBeVisible();
).toBeVisible(50);
found[accountFixtures.mentors[Number(i)].displayName] = true;
} catch (error) {
continue;
Expand Down
10 changes: 9 additions & 1 deletion e2e/signInTest.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@ import { by, element, expect, device } from 'detox';
import { describe, it, beforeEach, beforeAll } from '@jest/globals';
import accountFixtures from './fixtures/accounts.json';

import { APISignUpMentee, APIDeleteAccounts, signIn } from './helpers';
import {
APISignUpMentee,
APIDeleteAccounts,
signIn,
forceLogout,
} from './helpers';

describe('SignIn', () => {
beforeAll(async () => {
Expand All @@ -12,6 +17,9 @@ describe('SignIn', () => {
await APIDeleteAccounts();
await device.reloadReactNative();
});
afterEach(async () => {
await forceLogout();
});

it('mentee succesfully', async () => {
const mentee = accountFixtures.mentees[0];
Expand Down
2 changes: 1 addition & 1 deletion e2e/statusMessageTest.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe('Show status message', () => {

for (const mentorName of Object.keys(statusMessages)) {
try {
await expect(element(by.text(mentorName))).toBeVisible();
await expect(element(by.text(mentorName))).toBeVisible(50);
await expect(
element(by.text(statusMessages[mentorName])),
).toBeVisible();
Expand Down
9 changes: 7 additions & 2 deletions e2e/userReportTest.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
signIn,
forceLogout,
waitAndTypeText,
scrollDownAndTap,
} from './helpers';

describe('reportUser', () => {
Expand Down Expand Up @@ -68,7 +69,8 @@ describe('reportUser', () => {
const reportReason = 'Harrasment';
const contactInfo = '[email protected]';

await waitAndTypeText(descriptionTestId, reportReason);
await waitAndTypeText(descriptionTestId, reportReason, true);
await scrollDownAndTap('main.userreport.index.view', contactTestId);
await waitAndTypeText(contactTestId, contactInfo);

await element(by.id('main.userreport.send.button')).tap();
Expand Down Expand Up @@ -162,8 +164,11 @@ describe('reportUser', () => {

const descriptionTestId = 'main.userreport.description.input';
const contactTestId = 'main.userreport.contact.input';
const reportReason = 'Harrasment';

await waitAndTypeText(descriptionTestId, reportReason, true);
await element(by.id(descriptionTestId)).clearText();
await element(by.id(contactTestId)).tap();
await scrollDownAndTap('main.userreport.index.view', contactTestId);

// Now we see error
await expect(
Expand Down
7 changes: 7 additions & 0 deletions ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ target 'ylitse' do
:mac_catalyst_enabled => false
)
__apply_Xcode_12_5_M1_post_install_workaround(installer)

# https://stackoverflow.com/a/77136535
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)', '_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION']
end
end
end
end

6 changes: 3 additions & 3 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ PODS:
- React-perflogger (= 0.71.6)
- RNCAsyncStorage (1.18.1):
- React-Core
- RNDeviceInfo (10.11.0):
- RNDeviceInfo (10.12.0):
- React-Core
- RNFBApp (18.3.2):
- Firebase/CoreOnly (= 10.14.0)
Expand Down Expand Up @@ -794,7 +794,7 @@ SPEC CHECKSUMS:
React-runtimeexecutor: 8692ac548bec648fa121980ccb4304afd136d584
ReactCommon: 0c43eaeaaee231d7d8dc24fc5a6e4cf2b75bf196
RNCAsyncStorage: b90b71f45b8b97be43bc4284e71a6af48ac9f547
RNDeviceInfo: bf8a32acbcb875f568217285d1793b0e8588c974
RNDeviceInfo: db5c64a060e66e5db3102d041ebe3ef307a85120
RNFBApp: 0b534885354024f4d171ede8da04521d81bc1767
RNFBMessaging: a2ebefff4dd99eba6b16105bbc0b931bfdb0ce74
RNGestureHandler: 071d7a9ad81e8b83fe7663b303d132406a7d8f39
Expand All @@ -804,6 +804,6 @@ SPEC CHECKSUMS:
Yoga: ba09b6b11e6139e3df8229238aa794205ca6a02a
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

PODFILE CHECKSUM: 5420f96dab79d181a3c1ad392459902ee8895352
PODFILE CHECKSUM: 48004b0a41f3fdabc3a4ce2250b385f6ded12ae0

COCOAPODS: 1.12.0
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"size" : "83.5x83.5"
},
{
"filename" : "ylitse_vahemman_paddingia.png",
"filename" : "1024.png",
"idiom" : "ios-marketing",
"scale" : "1x",
"size" : "1024x1024"
Expand Down
Binary file not shown.
Loading
Loading