Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulp] Fix dynaconf obfuscation and add AUTH_LDAP_BIND_PASSWORD #3379

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

tuxpreacher
Copy link
Contributor

@tuxpreacher tuxpreacher commented Oct 10, 2023

An LDAP bind password can be present in /etc/pulp/settings.py when running an Ansible private automation hub. This needs to be obfuscated in both the settings.py file and in the dynaconf list output.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3379
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@pmoravec
Copy link
Contributor

pmoravec commented Oct 10, 2023

Just please follow DCO / and Signed-off-by: .. to the commit message.

.. and fix the styling issues :)

sos/report/plugins/pulp.py:173:80: E501 line too long (109 > 79 characters)
sos/report/plugins/pulp.py:176:80: E501 line too long (120 > 79 characters)

@pmoravec
Copy link
Contributor

Please squash the commits into one :). ACK otherwise.

@tuxpreacher
Copy link
Contributor Author

You're killing me. ;-) Let me figure out how to combine them.

Signed-off-by: Dr. Jason Breitweg <[email protected]>

Fixed style issues
Signed-off-by: Jason Breitweg [email protected]

Signed-off-by: Dr. Jason Breitweg <[email protected]>

Fixed yet more linting errors
Signed-off-by: Jason Breitweg [email protected]

Signed-off-by: Dr. Jason Breitweg <[email protected]>
@TurboTurtle TurboTurtle merged commit c6ab24e into sosreport:main Oct 10, 2023
34 checks passed
pmoravec added a commit to pmoravec/sos that referenced this pull request Oct 18, 2023
Likewise in sosreport#3379, scrub the password also in pulpcore plugin.

Resolves: sosreport#3389

Signed-off-by: Pavel Moravec <[email protected]>
TurboTurtle pushed a commit that referenced this pull request Oct 18, 2023
Likewise in #3379, scrub the password also in pulpcore plugin.

Resolves: #3389

Signed-off-by: Pavel Moravec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants