Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulpcore] Scrub AUTH_LDAP_BIND_PASSWORD value #3389

Merged

Conversation

pmoravec
Copy link
Contributor

Likewise in #3379, scrub the password also in pulpcore plugin.

Resolves: #3389


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Likewise in sosreport#3379, scrub the password also in pulpcore plugin.

Resolves: sosreport#3389

Signed-off-by: Pavel Moravec <[email protected]>
@pmoravec
Copy link
Contributor Author

Both pulp and pulpcore plugins collect the same file and command output which is not ideal. Gladly both plugins can be enabled by default only when having both pulp-2 and pulp-3 installed (quite rare situations) and even in that case, since the file should fit in any logsize limit, collecting it by two plugins should not harm.

The ideal solution will probably be merging plugins together - but that has some cons as well we can discuss later.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3389
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@pmoravec
Copy link
Contributor Author

Hi @TurboTurtle , could you please also review and ideally merge today?

@TurboTurtle TurboTurtle merged commit 5a285e6 into sosreport:main Oct 18, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants