Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulpcore] Scrub AUTH_LDAP_BIND_PASSWORD value #3389

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[pulpcore] Scrub AUTH_LDAP_BIND_PASSWORD value #3389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 8 additions & 19 deletions sos/report/plugins/pulpcore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,29 +144,18 @@ def build_query_cmd(self, query, csv=False):
return _dbcmd % (self.dbhost, self.dbport, self.dbname, quote(query))

def postproc(self):
# TODO obfuscate from /etc/pulp/settings.py :
# obfuscate from /etc/pulp/settings.py and "dynaconf list":
# SECRET_KEY = "eKfeDkTnvss7p5WFqYdGPWxXfHnsbDBx"
# 'PASSWORD': 'tGrag2DmtLqKLTWTQ6U68f6MAhbqZVQj',
# AUTH_LDAP_BIND_PASSWORD = 'ouch-a-secret'
# the PASSWORD can be also in an one-liner list, so detect its value
# in non-greedy manner till first ',' or '}'
self.do_path_regex_sub(
"/etc/pulp/settings.py",
r"(SECRET_KEY\s*=\s*)(.*)",
r"\1********")
self.do_path_regex_sub(
"/etc/pulp/settings.py",
r"(PASSWORD\S*\s*:\s*)(.*?)(,|\})",
r"\1********\3")
# apply the same for "dynaconf list" output that prints settings.py
# in a pythonic format
self.do_cmd_output_sub(
"dynaconf list",
r"(SECRET_KEY<str>\s*)'(.*)'",
r"\1********")
self.do_cmd_output_sub(
"dynaconf list",
r"(PASSWORD\S*\s*:\s*)(.*)",
r"\1********")
key_pass_re = r"((?:SECRET_KEY|AUTH_LDAP_BIND_PASSWORD)" \
r"(?:\<.+\>)?(\s*=)?|(password|PASSWORD)" \
r"(\"|'|:)+)\s*(\S*)"
repl = r"\1 ********"
self.do_path_regex_sub("/etc/pulp/settings.py", key_pass_re, repl)
self.do_cmd_output_sub("dynaconf list", key_pass_re, repl)


# vim: set et ts=4 sw=4 :