Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: fix multigather output by adding md5sum along with -U/--output-add-query-md5sum #2722

Merged
merged 28 commits into from
Feb 29, 2024

Commits on May 28, 2022

  1. Uniquify csv output from multigather

    Hello!
    Hope you and yours are doing well. I am using multigather to query protein sequences against each other, and primarily use the csv file for downstream processing. As is, if the signatures in `--query query.sig` were created from one fasta file with e.g. `--singleton`, then all results iteratively overwrite each other into the same csv file. This proposed change adds the md5sum to the query file to ensure uniqueness. Other suggestions are welcome!
    
    (not tested yet)
    
    Warmest,
    Olga
    olgabot authored May 28, 2022
    Configuration menu
    Copy the full SHA
    db08838 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. Merge branch 'latest' of https://github.com/sourmash-bio/sourmash int…

    …o ctb_update_2065
    ctb committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    3e4a2d3 View commit details
    Browse the repository at this point in the history
  2. fix merge mistake

    ctb committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    db99f6d View commit details
    Browse the repository at this point in the history
  3. Merge branch 'latest' of https://github.com/sourmash-bio/sourmash int…

    …o ctb_update_2065
    ctb committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    4f73ab7 View commit details
    Browse the repository at this point in the history
  4. update 2065

    ctb committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    29b7acf View commit details
    Browse the repository at this point in the history
  5. deal with overwriting in tests

    ctb committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    096e116 View commit details
    Browse the repository at this point in the history
  6. add tests for detecting overwrite

    ctb committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    8a54cc5 View commit details
    Browse the repository at this point in the history
  7. fix filename == '-' issue

    ctb committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    5fcd12a View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. MRG: update #2065 (uniquify CSV output from multigather) (#2721)

    Note: PR into #2065.
    
    This PR updates #2065 with all the changes from `latest`. This includes
    the fix & update to multigather in
    #2322, which:
    - fixes the output of multigather to include more than one line 😆 
    - prints out the output filename
    - supports `--output-dir`
    
    No functional changes are made beyond the merge, so some tests are still
    failing; will discuss fixes in yet a new PR :).
    
    ---------
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: Keya Barve <[email protected]>
    Co-authored-by: ccbaumler <[email protected]>
    Co-authored-by: Tessa Pierce Ward <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Taylor Reiter <[email protected]>
    Co-authored-by: Erik Young <[email protected]>
    Co-authored-by: David Koslicki <[email protected]>
    Co-authored-by: Luiz Irber <[email protected]>
    Co-authored-by: Colton Baumler <[email protected]>
    Co-authored-by: Luiz Irber <[email protected]>
    Co-authored-by: N. Tessa Pierce-Ward <[email protected]>
    Co-authored-by: Peter Cock <[email protected]>
    Co-authored-by: Francesco Beghini <[email protected]>
    Co-authored-by: Jason Stajich <[email protected]>
    Co-authored-by: Katrin Leinweber <[email protected]>
    16 people authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    323d2c3 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'latest' of https://github.com/sourmash-bio/sourmash int…

    …o olgabot-patch-2
    ctb committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4e148a0 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'olgabot-patch-2' of https://github.com/sourmash-bio/sou…

    …rmash into fix_multigather_output
    ctb committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    6a8bf5f View commit details
    Browse the repository at this point in the history
  4. add some docs

    ctb committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    2c6b194 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. add new option + tests + docs

    ctb committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    d6dd054 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. cleanup on aisle 10

    ctb committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0b7b7f6 View commit details
    Browse the repository at this point in the history
  2. more cleanup of tests

    ctb committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    53e7241 View commit details
    Browse the repository at this point in the history
  3. test -E/--extension

    ctb committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3d0467e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Merge branch 'latest' of https://github.com/sourmash-bio/sourmash int…

    …o fix_multigather_output
    ctb committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    5905e18 View commit details
    Browse the repository at this point in the history
  2. typo

    ctb committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    eba4d2a View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Merge branch 'latest' of https://github.com/sourmash-bio/sourmash int…

    …o fix_multigather_output_merge
    ctb committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    556bf3f View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. fix multigather argparse

    ctb committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7296cb7 View commit details
    Browse the repository at this point in the history
  2. cleanup from merge

    ctb committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e8bb12f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3589780 View commit details
    Browse the repository at this point in the history
  4. text fix/cleanup attempt 1

    ctb committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7878886 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. fix multigather test

    ctb committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    8b3f708 View commit details
    Browse the repository at this point in the history
  2. fix up documentation a bit

    ctb committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d436bca View commit details
    Browse the repository at this point in the history
  3. fix remaining @ctb

    ctb committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4d3059e View commit details
    Browse the repository at this point in the history
  4. add tests for -U

    ctb committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    839f4ef View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1265d82 View commit details
    Browse the repository at this point in the history