-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gold & Silver wall resprite #32099
Open
TheShuEd
wants to merge
4
commits into
space-wizards:master
Choose a base branch
from
TheShuEd:ed-12-09-2024-silver-wall
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gold & Silver wall resprite #32099
+92
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
No C#
For things that don't need code.
Changes: Sprites
Should be reviewed or fixed by people who are knowledgeable with spriting or visual design.
labels
Sep 12, 2024
RSI Diff Bot; head commit 12d6f19 merging into d18dba9 Resources/Textures/Structures/Walls/gold.rsi
Resources/Textures/Structures/Walls/silver.rsi
|
github-actions
bot
added
the
Status: Needs Review
This PR requires new reviews before it can be merged.
label
Sep 12, 2024
Gold looks good but silver doesn't look silver to me. It looks more like steel to me. Can you make it brighter in the center? |
Border of the walls is too bright |
the butter room |
Flareguy feedback applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: Sprites
Should be reviewed or fixed by people who are knowledgeable with spriting or visual design.
No C#
For things that don't need code.
Status: Needs Review
This PR requires new reviews before it can be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Resprited to the same style as default solid walls
Media
Before:
After: