AI now "can" use media console #32334
Merged
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x6273
suggested changes
Sep 21, 2024
Comment on lines
-312
to
-314
| // This shouldn't technically be possible because of BUI but don't trust client. | ||
| if (!_interaction.InRangeUnobstructed(console, user)) | ||
| return false; |
There was a problem hiding this comment.
This removes the check for everyone, not just AI.
There was a problem hiding this comment.
I don't understand why we even need this check. The comment says it "should't technically be possible". If I go from the console it just closes (watch attachment). Also haven't seen such check in other consoles' code.
Content.client.2024.09.22.-.10.35.09.06.mp4
There was a problem hiding this comment.
BUI should be handling this, yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Lets AI to use console that is far away from his core.
Why / Balance
Currently AI is able to use media console that is NEAR his core (so basically AI never get in such situation)
Technical details
Deletes some code that don't allow to use console. Comment in the code: "This shouldn't technically be possible because of BUI but don't trust client"
Media
Requirements
Changelog
🆑