Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI now "can" use media console #32334

Merged
merged 1 commit into from
Sep 22, 2024
Merged

AI now "can" use media console #32334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Content.Server/MassMedia/Systems/NewsSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,9 +309,6 @@ private void UpdateWriterDevices()

private bool CanUse(EntityUid user, EntityUid console)
{
// This shouldn't technically be possible because of BUI but don't trust client.
if (!_interaction.InRangeUnobstructed(console, user))
return false;
Comment on lines -312 to -314
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the check for everyone, not just AI.

Copy link
Contributor Author

@AsnDen AsnDen Sep 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we even need this check. The comment says it "should't technically be possible". If I go from the console it just closes (watch attachment). Also haven't seen such check in other consoles' code.

Content.client.2024.09.22.-.10.35.09.06.mp4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUI should be handling this, yes.


if (TryComp<AccessReaderComponent>(console, out var accessReaderComponent))
{
Expand Down
Loading